Project

General

Profile

Bug #42113

ceph -h usage should indicate CephChoices --name= is sometime required

Added by Sage Weil over 4 years ago. Updated over 4 years ago.

Status:
Fix Under Review
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

orchestrator device ls [<host>...] [json|plain] [--refresh]                                                 List devices on a node

but 'bin/ceph orchestrator device ls gnit json' results in
RuntimeError: Host(s) 'json' not registered

The help should show '[--format=json|plain]' because the previous position is an 'n=N' arg.

Related issues

Duplicated by Orchestrator - Bug #40801: ceph orchestrator cli alleges support for json-pretty, xml, xml-pretty formats Duplicate

History

#1 Updated by Sage Weil over 4 years ago

  • Tags set to low-hanging-fruit

#2 Updated by Greg Farnum over 4 years ago

  • Priority changed from High to Normal

No failures so this is normal priority?

#3 Updated by Matthew Oliver over 4 years ago

Can't seem to assign this to myself. But I have the first version of the patch coming.

#4 Updated by Kefu Chai over 4 years ago

  • Status changed from 12 to Fix Under Review
  • Pull request ID set to 31042

@Matthew thanks for your contribution! the reason why you could not assign this ticket is that you are not listed in "Developer" of Ceph project, see https://tracker.ceph.com/projects/ceph .

#5 Updated by Sebastian Wagner over 4 years ago

  • Duplicated by Bug #40801: ceph orchestrator cli alleges support for json-pretty, xml, xml-pretty formats added

#6 Updated by Sebastian Wagner over 4 years ago

Marked #40801 as duplicate. Actually #40801 was first, but got little attention.

#7 Updated by Matthew Oliver over 4 years ago

Sebastian Wagner wrote:

Marked #40801 as duplicate. Actually #40801 was first, but got little attention.

From what I can see #40801 is slightly different. In that if you do send an '--format=non-existant-format' it will then five you format options that aren't supported, or if they are not mentioned in the 'help'.

I'll try and address both in the same patch (or is that too much scope creep?)

#8 Updated by Matthew Oliver over 4 years ago

Matthew Oliver wrote:

I'll try and address both in the same patch (or is that too much scope creep?)

Seems the full list is more prevelent and may be coming from outside the python code. The full -f list is in the `--help`. So suddenly isn't as such an obvious fix. But if we want to add them both together, I'll continue down the rabbit hole. (as at least it helps teach me to navigate different parts of the codebase) :P

Also available in: Atom PDF