Project

General

Profile

Actions

Feature #4207

closed

osd/librados: add ops to list snaps for an object

Added by Sage Weil about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
OSD
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Add an op to list snapshot metadata for an object. Similar to the list watchers change in #3403, need to define a type for the metadata (which should include snaps, clone overlap, size, etc.), define an op code, add bindings in the librados API to make it usable, and a rados CLI command to do it.

Actions #1

Updated by Sage Weil about 11 years ago

  • Description updated (diff)
  • Category set to OSD
Actions #2

Updated by Sage Weil about 11 years ago

  • Target version set to v0.59
Actions #3

Updated by David Zafman about 11 years ago

  • Status changed from 12 to In Progress
Actions #4

Updated by David Zafman about 11 years ago

  • Assignee set to David Zafman
Actions #5

Updated by David Zafman about 11 years ago

  • Status changed from In Progress to Fix Under Review
Actions #6

Updated by Ian Colle about 11 years ago

  • Translation missing: en.field_story_points changed from 3.00 to 8.00
Actions #7

Updated by David Zafman about 11 years ago

Sample output:

rados -p pool listsnaps testfile
testfile:
cloneid    snaps    size    overlap
3    2,3    1152    [0~128,256~128,512~128,768~128,1024~128]
4    4    1280    [0~128,256~256,768~256,1152~128]
head    -    1280

rados -p pool listsnaps testfile --format=json --pretty_format
{ "name": "testfile",
  "clones": [
        { "id": 3,
          "snapshots": [
                { "id": 2},
                { "id": 3}],
          "size": 1152,
          "overlaps": [
                { "start": 0,
                  "length": 128},
                { "start": 256,
                  "length": 128},
                { "start": 512,
                  "length": 128},
                { "start": 768,
                  "length": 128},
                { "start": 1024,
                  "length": 128}]},
        { "id": 4,
          "snapshots": [
                { "id": 4}],
          "size": 1280,
          "overlaps": [
                { "start": 0,
                  "length": 128},
                { "start": 256,
                  "length": 256},
                { "start": 768,
                  "length": 256},
                { "start": 1152,
                  "length": 128}]},
        { "id": "head",
          "snapshots": [],
          "size": 1280}]}

rados -p pool listsnaps testfile --format=xml --pretty_format
<object>
 <name>testfile</name>
 <clones>
  <clone>
   <id>3</id>
   <snapshots>
    <snapshot>
     <id>2</id>
    </snapshot>
    <snapshot>
     <id>3</id>
    </snapshot>
   </snapshots>
   <size>1152</size>
   <overlaps>
    <section>
     <start>0</start>
     <length>128</length>
    </section>
    <section>
     <start>256</start>
     <length>128</length>
    </section>
    <section>
     <start>512</start>
     <length>128</length>
    </section>
    <section>
     <start>768</start>
     <length>128</length>
    </section>
    <section>
     <start>1024</start>
     <length>128</length>
    </section>
   </overlaps>
  </clone>
  <clone>
   <id>4</id>
   <snapshots>
    <snapshot>
     <id>4</id>
    </snapshot>
   </snapshots>
   <size>1280</size>
   <overlaps>
    <section>
     <start>0</start>
     <length>128</length>
    </section>
    <section>
     <start>256</start>
     <length>256</length>
    </section>
    <section>
     <start>768</start>
     <length>256</length>
    </section>
    <section>
     <start>1152</start>
     <length>128</length>
    </section>
   </overlaps>
  </clone>
  <clone>
   <id>head</id>
   <snapshots>
   </snapshots>
   <size>1280</size>
  </clone>
 </clones>
</object>

Actions #8

Updated by David Zafman about 11 years ago

  • Status changed from Fix Under Review to Resolved

commit 3bd48cbbadb7908dd833ccde75359f085828fc5c
Merge: af6b6ed 7cd1cb2
Author: David Zafman <>
Date: Tue Mar 5 10:25:49 2013 -0800

Merge branch 'wip-4207'
Feature: #4207: osd/librados: add ops to list snaps for an object
Signed-off-by: David Zafman &lt;&gt;
Reported-by: Sam Just &lt;&gt;
Actions

Also available in: Atom PDF