Bug #41776
closedmgr/dashboard: unable to set boolean values to false when default is true
0%
Description
The issue was originally reported on ceph-users mailinglist: http://lists.ceph.com/pipermail/ceph-users-ceph.com/2019-September/036801.html
In the config option editor it's currently not possible to set boolean values to false when the default value is true.
Files
Updated by Tatjana Dehler over 4 years ago
- Related to Bug #42779: mgr/dashboard: cluster configuration 'boolean' and other improvements added
Updated by Ricardo Marques over 4 years ago
- Assignee changed from Ricardo Dias to Ricardo Marques
Updated by Ernesto Puerta over 4 years ago
@Ricardo Rocha, if you start working on this, I came up with a proposal in https://tracker.ceph.com/issues/42779. Basically, using a 'switch' (https://www.patternfly.org/v4/documentation/core/components/switch), but as Tatjana mentioned, we would need 3 states (there're tri-state patterns for both switches or check-boxes). However, I'm wondering how intuitive is that approach for users. Perhaps we should just have a left-side checkbox for overriding the default, and a switch for the True/False value, and that switch is disable if the default override is unticked? What about the following?
Updated by Ricardo Marques over 4 years ago
- File iscsi_yes_no.png iscsi_yes_no.png added
Instead of introducing a new UI component, maybe we can use something similar to what we already have in iSCSI:
(with an additional option "Default")
Alternatively, we can use a `dropdown` instead of a `radio`, but I'm more in favor of using a radio because dropdown requires an additional "click" to open the available options.
Updated by Tatjana Dehler over 4 years ago
Ricardo Marques wrote:
Instead of introducing a new UI component, maybe we can use something similar to what we already have in iSCSI:
Yes, I agree, we shouldn't add another UI component just because of the configs editor.
(with an additional option "Default")
Alternatively, we can use a `dropdown` instead of a `radio`, but I'm more in favor of using a radio because dropdown requires an additional "click" to open the available options.
I'm also more in favor of the radio buttons.
Updated by Ernesto Puerta over 4 years ago
Ok, perfect then. Also prefer to avoid the 1 extra click of the dropdown.
Updated by Ricardo Marques over 4 years ago
- Status changed from New to In Progress
Updated by Ricardo Marques over 4 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 31738
Updated by Lenz Grimmer over 4 years ago
- Status changed from Fix Under Review to Pending Backport
- Target version changed from v14.2.5 to v15.0.0
Updated by Nathan Cutler over 4 years ago
- Copied to Backport #42955: nautilus: mgr/dashboard: unable to set boolean values to false when default is true added
Updated by Nathan Cutler about 4 years ago
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".
Updated by Ernesto Puerta about 3 years ago
- Project changed from mgr to Dashboard
- Category changed from 158 to General - Configuration