Bug #41600: dashboard/services/sso.py:200: error: Too few arguments for "warn_explicit" - Dashboard - Ceph

Actions

Copy link

Bug #41600

closed

dashboard/services/sso.py:200: error: Too few arguments for "warn_explicit"

Added by Sebastian Wagner over 4 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ernesto Puerta

Category:

Security & Auth

Target version:

Ceph - v15.0.0

% Done:

Source:

Q/A

Tags:

Backport:

Regression:

Yes

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

30075

Crash signature (v1):

Crash signature (v2):

Description

mypy revealed:

+pybind/mgr/dashboard/services/sso.py: note: In function "handle_sso_command":
+pybind/mgr/dashboard/services/sso.py:200: error: Too few arguments for "warn_explicit"

This looks like a real bug to me.

See also: https://gist.github.com/sebastian-philipp/25f70aae3b0d21b1a781c110a7ef8be4

Actions

Copy link

Updated by Sebastian Wagner over 4 years ago

Description updated (diff)

Actions

Copy link

Updated by Ernesto Puerta over 4 years ago

Assignee set to Ernesto Puerta

Actions

Copy link

Updated by Lenz Grimmer over 4 years ago

Target version set to v15.0.0
Regression changed from No to Yes

04f4d5053e2 (Ricardo Marques 2018-06-11 10:29:08 +0100 196)         except FileNotFoundError:
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 197)             sp_private_key = ''
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 198) 
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 199)         if os.path.isfile(idp_metadata):
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 200)             warnings.warn_explicit(
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 201)                 "Please prepend 'file://' to indicate a local SAML2 IdP file", DeprecationWarning)
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 202)             with open(idp_metadata, 'r') as f:
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 203)                 idp_settings = Saml2Parser.parse(f.read(), entity_id=idp_entity_id)
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 204)         elif parse.urlparse(idp_metadata)[0] in ('http', 'https', 'file'):
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 205)             idp_settings = Saml2Parser.parse_remote(
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 206)                 url=idp_metadata, validate_cert=False, entity_id=idp_entity_id)
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 207)         else:
ff4fb0fbbde (Ernesto Puerta  2019-08-23 13:45:45 +0200 208)             idp_settings = Saml2Parser.parse(idp_metadata, entity_id=idp_entity_id)
04f4d5053e2 (Ricardo Marques 2018-06-11 10:29:08 +0100 209)

Ernesto, can you please take a look at this?

Actions

Copy link