Project

General

Profile

Bug #41574

mgr/dashboard: use consistent HTML titling hierarchies in forms

Added by Ernesto Puerta about 4 years ago. Updated over 1 year ago.

Status:
In Progress
Priority:
Normal
Category:
General
Target version:
-
% Done:

0%

Source:
Tags:
low-hanging-fruit, usability
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently forms (and other hierarchical elements) rely on HTML <h[1-6]> tags to define the structure of information/fields/etc. However they also use <legend> elements, or just <div>'s styled with *-header, *-body, *-group, etc.

That leads to inconsistent structure in the DOM, and often also weird appearance in forms and other elements.

Example: pool-form.component form's title is <h3>, then there's a <legend> element "Compression", which appears bigger than the Form header, and another sub-element with title <h3>. This also happens to other forms (RBD, etc).

We should agree whether we want to structure based on HTML headings (properly styled) or HTML5 <section> + classes with a consistent styling (e.g: PF4 does this), and refactor those elements.

XHTML 2 <h> would've been great here too, but unfortunately it seems it's born dead.

titles.png View (21.9 KB) Ernesto Puerta, 08/29/2019 11:30 AM

History

#1 Updated by Ernesto Puerta about 4 years ago

#2 Updated by Tiago Melo almost 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Tiago Melo

#3 Updated by Tiago Melo almost 4 years ago

  • Status changed from In Progress to 12
  • Assignee deleted (Tiago Melo)

#4 Updated by Ricardo Marques almost 4 years ago

+1 for fixing this

#5 Updated by Ricardo Marques almost 4 years ago

  • Tags set to low-hanging-fruit usability

#6 Updated by Ricardo Marques almost 4 years ago

  • Tags changed from low-hanging-fruit usability to low-hanging-fruit, usability

#7 Updated by Patrick Donnelly almost 4 years ago

  • Status changed from 12 to New

#8 Updated by Ernesto Puerta over 2 years ago

  • Tags set to low-hanging-fruit

#9 Updated by Ernesto Puerta over 2 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 132 to General

#10 Updated by Carolina Silva over 1 year ago

Can I work on this issue?

#11 Updated by Ernesto Puerta over 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Casey Bodley

Carolina Silva wrote:

Can I work on this issue?

Of course! Please, let us know if you need any help or guidance with it.

#12 Updated by Ernesto Puerta over 1 year ago

  • Assignee changed from Casey Bodley to Carolina Silva

Also available in: Atom PDF