Project

General

Profile

Actions
Copy link

Cleanup #4156

closed

qa: don't chown rbd stuff in rbd/* workunits

Added by Sage Weil about 11 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Once we are doing proper installs, we can call sudo as needed and not worry about $PATH etc.

Actions
Copy link
 #1

Updated by Sage Weil about 11 years ago

  • Tracker changed from Support to Cleanup
Actions
Copy link
 #2

Updated by Sage Weil about 11 years ago

  • Translation missing: en.field_position set to 88
Actions
Copy link
 #3

Updated by Patrick Donnelly almost 6 years ago

  • Project changed from Ceph to rbd
  • Category deleted (qa)
Actions
Copy link
 #4

Updated by Nathan Cutler almost 6 years ago

  • Status changed from New to Resolved

This ticket is 5 years old, i.e. around the time of the 0.67 release:

smithfarm@wilbur:~/src/ceph/smithfarm/ceph/qa/workunits/rbd> git describe
v0.67
smithfarm@wilbur:~/src/ceph/smithfarm/ceph/qa/workunits/rbd> ag chown
concurrent.sh
87:     sudo chown ubuntu /sys/bus/rbd/add /sys/bus/rbd/remove
120:    sudo chown root /sys/bus/rbd/add /sys/bus/rbd/remove

image_read.sh
269:            sudo chown ubuntu /sys/bus/rbd/add
270:            sudo chown ubuntu /sys/bus/rbd/remove
315:            sudo chown root /sys/bus/rbd/add
316:            sudo chown root /sys/bus/rbd/remove
369:            sudo chown ubuntu $(image_dev_path "${image_name}")
384:            [ "${SUSER}" = true ] || sudo chown root "${image_path}" 

map-unmap.sh
76:     sudo chown ubuntu /sys/bus/rbd/add
77:     sudo chown ubuntu /sys/bus/rbd/remove
85:     sudo chown root /sys/bus/rbd/remove     || true
86:     sudo chown root /sys/bus/rbd/add        || true

kernel.sh
28:     sudo chown root /sys/bus/rbd/add /sys/bus/rbd/remove
40:sudo chown ubuntu /sys/bus/rbd/add /sys/bus/rbd/remove

map-snapshot-io.sh
7:sudo chown ubuntu /sys/bus/rbd/add
8:sudo chown ubuntu /sys/bus/rbd/remove

Fast-forwarding to today:

smithfarm@wilbur:~/src/ceph/smithfarm/ceph/qa/workunits/rbd> git describe
v14.0.0-1512-ga2dcee6ce3
smithfarm@wilbur:~/src/ceph/smithfarm/ceph/qa/workunits/rbd> ag chown
run_devstack_tempest.sh
125:chown -R ${TEMPEST_USER}:${STACK_GROUP} ${STACK_OPT_PATH}/tempest
126:chown -R ${TEMPEST_USER}:${STACK_GROUP} ${STACK_OPT_PATH}/data/tempest

So it looks done to me.

Actions
Copy link

Also available in: Atom PDF