Project

General

Profile

Actions
Copy link

Bug #41156

closed

dump_float() poor output

Added by David Zafman over 4 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
29545
Crash signature (v1):
Crash signature (v2):

Description

dump_float("15min", 810 / 1000.0) outputs "15min": 0.8100000000000001

This was introduced in https://github.com/ceph/ceph/pull/25745 which has 1 commit and no tracker.

While using a template to create the add_value() functions the issue is caused by m_ss.precision(std::numeric_limits<T>::max_digits10);

Related issues 1 (1 open — 0 closed)

Related to RADOS - Bug #41754: Use dump_stream() instead of dump_float() for floats where max precision isn't helpfulNewDavid Zafman09/10/2019

Actions
Actions
Copy link
 #1

Updated by David Zafman over 4 years ago

  • Pull request ID set to 29545
Actions
Copy link
 #2

Updated by David Zafman over 4 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by David Zafman over 4 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by David Zafman over 4 years ago

  • Status changed from In Progress to Won't Fix
Actions
Copy link
 #5

Updated by David Zafman over 4 years ago

  • Status changed from Won't Fix to 12

Looking at osd dump output in teuthology.log on a test run and I this see output which is ugly:

"full_ratio": 0.949999988079071,
  "backfillfull_ratio": 0.8999999761581421,
  "nearfull_ratio": 0.8500000238418579,
"weight": 0.904632568359375,
      "primary_affinity": 0.451995849609375,
Actions
Copy link
 #6

Updated by David Zafman over 4 years ago

  • Backport set to nautilus
Actions
Copy link
 #7

Updated by David Zafman over 4 years ago

  • Status changed from 12 to Rejected
Actions
Copy link
 #8

Updated by David Zafman over 4 years ago

  • Related to Bug #41754: Use dump_stream() instead of dump_float() for floats where max precision isn't helpful added
Actions
Copy link

Also available in: Atom PDF