https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2019-07-30T14:42:45ZCeph bluestore - Bug #41009: osd_memory_target isn't applied in runtime.https://tracker.ceph.com/issues/41009?journal_id=1420742019-07-30T14:42:45ZJosh Durgin
<ul><li><strong>Assignee</strong> set to <i>Sridhar Seshasayee</i></li></ul><p>Sridhar was planning on working on this after the mon_memory_target (<a class="external" href="https://github.com/ceph/ceph/pull/28227">https://github.com/ceph/ceph/pull/28227</a>) - I hadn't realized it used to be injectable. The cache autotuning does need a config observer to be able to adjust things properly when relevant options change.</p> bluestore - Bug #41009: osd_memory_target isn't applied in runtime.https://tracker.ceph.com/issues/41009?journal_id=1427722019-08-12T13:51:05ZSridhar Seshasayee
<ul><li><strong>Pull request ID</strong> set to <i>29606</i></li></ul><p>PR <a class="external" href="https://github.com/ceph/ceph/pull/29606">https://github.com/ceph/ceph/pull/29606</a> is raised that addresses this issue.</p>
<p>Tested this using vstart and here are some logs of interest to confirm that the change works,</p>
<p>1. Change the default osd_memory_target to 2_G from 4_G.</p>
<pre>
MempoolThread picks up the value saved in bluestore object and updated the pcm,
58212 2019-08-12T16:13:35.547+0530 7f0d71334700 5 bluestore.MempoolThread(0x55f3f27dbd90) _update_cache_settings updated pcm target: 2147483648
Eventually the cache size is recalculated as part of _resize_shards shown below,
58274 2019-08-12T16:13:36.451+0530 7f0d71334700 20 bluestore.MempoolThread(0x55f3f27dbd90) _resize_shards cache_size: 1020054732 kv_alloc: 1073741824 kv_used: 1824 meta_alloc: 1073741824 me ta_used: 124604 data_alloc: 671088640 data_used: 0
...
...
58467 2019-08-12T16:13:40.471+0530 7f0d71334700 10 rocksdb: commit_cache_size old: 1073741824 new: 390070272
58468 2019-08-12T16:13:40.471+0530 7f0d71334700 10 rocksdb: commit_cache_size High Pri Pool Ratio set to 0.017348
58469 2019-08-12T16:13:40.471+0530 7f0d71334700 5 bluestore.MempoolThread(0x55f3f27dbd90) _resize_shards cache_size: 1020054732 kv_alloc: 390070272 kv_used: 1824 meta_alloc: 390070272 meta _used: 124604 data_alloc: 230686720 data_used: 0
</pre>
<p>2. Pass an invalid osd_memory_target value of 0.<br /><pre>
2019-08-12T18:35:10.141+0530 7ff5ff307700 -1 bluestore(/home/sseshasa/workspaces/ceph/build/dev/osd0) _update_osd_memory_target_size osd_memory_target:0. Invalid size provided.
</pre></p>
<p>As observed above, the invalid value is detected and bluestore object is not updated.</p> bluestore - Bug #41009: osd_memory_target isn't applied in runtime.https://tracker.ceph.com/issues/41009?journal_id=1427902019-08-12T20:49:25ZNeha Ojhanojha@redhat.com
<ul><li><strong>Backport</strong> set to <i>nautilus</i></li></ul> bluestore - Bug #41009: osd_memory_target isn't applied in runtime.https://tracker.ceph.com/issues/41009?journal_id=1459302019-09-12T11:53:04ZSridhar Seshasayee
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Pending Backport</i></li></ul> bluestore - Bug #41009: osd_memory_target isn't applied in runtime.https://tracker.ceph.com/issues/41009?journal_id=1460422019-09-13T09:11:51ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-4 priority-default closed" href="/issues/41810">Backport #41810</a>: nautilus: osd_memory_target isn't applied in runtime.</i> added</li></ul> bluestore - Bug #41009: osd_memory_target isn't applied in runtime.https://tracker.ceph.com/issues/41009?journal_id=1551572020-01-07T14:47:23ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li></ul><p>While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".</p> bluestore - Bug #41009: osd_memory_target isn't applied in runtime.https://tracker.ceph.com/issues/41009?journal_id=1579132020-02-06T10:32:15ZIgor Fedotovigor.fedotov@croit.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-10 priority-4 priority-default closed" href="/issues/44010">Bug #44010</a>: changing osd_memory_target currently requires restart, should update at runtime</i> added</li></ul>