Project

General

Profile

Actions
Copy link

Cleanup #40992

closed

cephfs-shell: Multiple flake8 errors

Added by Varsha Rao over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Varsha Rao
Category:
Code Hygiene
Target version:
Ceph - v15.0.0
% Done:

0%

Tags:
Backport:
nautilus
Reviewed:
Affected Versions:
Component(FS):
cephfs-shell
Labels (FS):
Pull request ID:
29374

Description

After ignoring E501 and W503 flake8 errors, following needs to be fixed:

(venv) [root@localhost ceph]# flake8 --ignore=E501,W503 src/tools/cephfs/cephfs-shell
src/tools/cephfs/cephfs-shell:80:28: E241 multiple spaces after ':'
src/tools/cephfs/cephfs-shell:171:47: E226 missing whitespace around arithmetic operator
src/tools/cephfs/cephfs-shell:770:64: W504 line break after binary operator
src/tools/cephfs/cephfs-shell:771:37: W504 line break after binary operator
src/tools/cephfs/cephfs-shell:772:36: W504 line break after binary operator
src/tools/cephfs/cephfs-shell:776:57: W504 line break after binary operator
src/tools/cephfs/cephfs-shell:777:54: W504 line break after binary operator
src/tools/cephfs/cephfs-shell:778:40: W504 line break after binary operator
src/tools/cephfs/cephfs-shell:779:39: W504 line break after binary operator
src/tools/cephfs/cephfs-shell:1070:48: E226 missing whitespace around arithmetic operator
src/tools/cephfs/cephfs-shell:1074:40: E226 missing whitespace around arithmetic operator
src/tools/cephfs/cephfs-shell:1226:37: E226 missing whitespace around arithmetic operator
src/tools/cephfs/cephfs-shell:1242:19: E126 continuation line over-indented for hanging indent
src/tools/cephfs/cephfs-shell:1289:44: E226 missing whitespace around arithmetic operator

E501 line too long
W503 line break before binary operator

Related issues 1 (0 open — 1 closed)

Copied to CephFS - Backport #41089: nautilus: cephfs-shell: Multiple flake8 errorsRejectedActions
Actions
Copy link
 #1

Updated by Varsha Rao over 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 29374
Actions
Copy link
 #2

Updated by Varsha Rao over 4 years ago

Not ignoring E501 instead limiting line length to 100.

cephfs-shell:80:28: E241 multiple spaces after ':'
cephfs-shell:171:47: E226 missing whitespace around arithmetic operator
cephfs-shell:185:101: E501 line too long (101 > 100 characters)
cephfs-shell:770:64: W504 line break after binary operator
cephfs-shell:771:37: W504 line break after binary operator
cephfs-shell:772:36: W504 line break after binary operator
cephfs-shell:776:57: W504 line break after binary operator
cephfs-shell:777:54: W504 line break after binary operator
cephfs-shell:778:40: W504 line break after binary operator
cephfs-shell:779:39: W504 line break after binary operator
cephfs-shell:1070:48: E226 missing whitespace around arithmetic operator
cephfs-shell:1074:40: E226 missing whitespace around arithmetic operator
cephfs-shell:1226:37: E226 missing whitespace around arithmetic operator
cephfs-shell:1242:19: E126 continuation line over-indented for hanging indent
cephfs-shell:1289:44: E226 missing whitespace around arithmetic operator
Actions
Copy link
 #3

Updated by Patrick Donnelly over 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #4

Updated by Patrick Donnelly over 4 years ago

  • Copied to Backport #41089: nautilus: cephfs-shell: Multiple flake8 errors added
Actions
Copy link
 #5

Updated by Nathan Cutler over 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF