Bug #40779
Unable to reset / unset module options
% Done:
0%
Source:
Development
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Description
MgrModule.set_module_option('x', None)
is supposed to reset module options. This is broken.
void PyModuleConfig::set_config()
accepts a boost::optional<std::string>
as value, which is `false` if the optional is unset.
But ceph_set_module_option
doesn't pass None
to PyModuleConfig::set_config()
Result: there is no way to unset a setting
Affects dashboard and orchestrator_cli
Related issues
History
#1 Updated by Sebastian Wagner over 1 year ago
- Assignee set to Sebastian Wagner
#3 Updated by Sebastian Wagner over 1 year ago
- Pull request ID set to 29042
#4 Updated by Sebastian Wagner over 1 year ago
- Backport set to nautilus
#5 Updated by Sebastian Wagner over 1 year ago
- Status changed from New to Fix Under Review
#6 Updated by Sebastian Wagner over 1 year ago
- Status changed from Fix Under Review to Pending Backport
#7 Updated by Tatjana Dehler over 1 year ago
- Copied to Backport #40878: nautilus: Unable to reset / unset module options added
#8 Updated by Nathan Cutler over 1 year ago
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".