Project

General

Profile

Bug #40779

Unable to reset / unset module options

Added by Sebastian Wagner 2 months ago. Updated about 2 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Sebastian Wagner
Category:
python interface
Target version:
-
Start date:
07/15/2019
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
29042

Description

MgrModule.set_module_option('x', None) is supposed to reset module options. This is broken.

void PyModuleConfig::set_config() accepts a boost::optional<std::string> as value, which is `false` if the optional is unset.
But ceph_set_module_option doesn't pass None to PyModuleConfig::set_config()

Result: there is no way to unset a setting

Affects dashboard and orchestrator_cli

Related issues

Copied to mgr - Backport #40878: nautilus: Unable to reset / unset module options In Progress

History

#1 Updated by Sebastian Wagner 2 months ago

  • Assignee set to Sebastian Wagner

#3 Updated by Sebastian Wagner 2 months ago

  • Pull request ID set to 29042

#4 Updated by Sebastian Wagner 2 months ago

  • Backport set to nautilus

#5 Updated by Sebastian Wagner 2 months ago

  • Status changed from New to Need Review

#6 Updated by Sebastian Wagner about 2 months ago

  • Status changed from Need Review to Pending Backport

#7 Updated by Tatjana Dehler about 2 months ago

  • Copied to Backport #40878: nautilus: Unable to reset / unset module options added

Also available in: Atom PDF