Project

General

Profile

Backport #40768

nautilus: mgr/dashboard: change Github dep ng2-toastr to NPMJS

Added by Ernesto Puerta over 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Target version:
Release:
nautilus
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/29050


Currently there's a node dependency from a Github repo. This breaks support for offline NPM usage (by means of tarball or cache). This is fixed in master in Bootstrap update (https://github.com/ceph/ceph/pull/25188, specifically this commit: https://github.com/ceph/ceph/commit/67f5e5b18b71ccabcaa8d9e35c57630d17395b06#diff-1940c08371e60aaf8a19a76266ee6bf3L80 + some trivial additions).

History

#1 Updated by Ernesto Puerta over 3 years ago

4.2.1 is triggering the following error:
"ERROR in node_modules/ng2-toastr/src/toast-container.component.d.ts(1,48): error TS2305: Module '"../../@angular/core/core"' has no exported member 'AnimationTransitionEvent'."

Maybe upgrading to other toastr package?

#2 Updated by Ernesto Puerta over 3 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Target version set to v14.2.2
  • Backport set to nautilus
  • Affected Versions v14.2.0, v14.2.1, v14.2.2 added

#3 Updated by Ernesto Puerta over 3 years ago

  • Pull request ID set to 29050

#4 Updated by Ernesto Puerta over 3 years ago

  • Tracker changed from Bug to Backport
  • Release set to nautilus

#5 Updated by Ernesto Puerta over 3 years ago

  • Subject changed from mgr/dashboard: change Github dep ng2-toastr to NPMJS to nautilus: mgr/dashboard: change Github dep ng2-toastr to NPMJS

#6 Updated by Ernesto Puerta over 3 years ago

  • Status changed from In Progress to Resolved

#7 Updated by Nathan Cutler over 3 years ago

  • Target version changed from v14.2.2 to v14.2.3

#8 Updated by Nathan Cutler over 3 years ago

  • Description updated (diff)

#9 Updated by Ernesto Puerta almost 2 years ago

  • Project changed from mgr to Dashboard

Also available in: Atom PDF