Project

General

Profile

Bug #4071

osd: snap coll not created on scrub trim repop

Added by Sage Weil about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
OSD
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
bobtail, argonaut
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

on replica:

2013-02-09 22:11:46.286883 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) collection_setattr /tmp/cephtest/data/osd.5.data/current/0.b_head 'info' len 5 = 5
2013-02-09 22:11:46.286894 7f702033e700 15 filestore(/tmp/cephtest/data/osd.5.data) truncate meta/dae1b193/pginfo_0.b/0//-1 size 0
2013-02-09 22:11:46.287034 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) truncate meta/dae1b193/pginfo_0.b/0//-1 size 0 = 0
2013-02-09 22:11:46.287054 7f702033e700 15 filestore(/tmp/cephtest/data/osd.5.data) write meta/dae1b193/pginfo_0.b/0//-1 0~627
2013-02-09 22:11:46.287355 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) write meta/dae1b193/pginfo_0.b/0//-1 0~627 = 627
2013-02-09 22:11:46.287519 7f702033e700 15 filestore(/tmp/cephtest/data/osd.5.data) setattrs 0.b_head/874f5bb/plana739334-37/4//0
2013-02-09 22:11:46.287687 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) setattrs 0.b_head/874f5bb/plana739334-37/4//0 = 206
2013-02-09 22:11:46.287702 7f702033e700 15 filestore(/tmp/cephtest/data/osd.5.data) remove 0.b_4/874f5bb/plana739334-37/4//0
2013-02-09 22:11:46.319765 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) remove 0.b_4/874f5bb/plana739334-37/4//0 = 0
2013-02-09 22:11:46.319793 7f702033e700 15 filestore(/tmp/cephtest/data/osd.5.data) collection_add 0.b_3/874f5bb/plana739334-37/4//0 from 0.b_head/874f5bb/plana739334-37/4//0
2013-02-09 22:11:46.369823 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) collection_add 0.b_3/874f5bb/plana739334-37/4//0 from 0.b_head/874f5bb/plana739334-37/4//0 = -2
2013-02-09 22:11:46.369950 7f702033e700 15 filestore(/tmp/cephtest/data/osd.5.data) setattrs 0.b_head/874f5bb/plana739334-37/head//0
2013-02-09 22:11:46.370161 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) setattrs 0.b_head/874f5bb/plana739334-37/head//0 = 107
2013-02-09 22:11:46.370269 7f702033e700 15 filestore(/tmp/cephtest/data/osd.5.data) setattrs 0.b_head/874f5bb/plana739334-37/head//0
2013-02-09 22:11:46.370429 7f702033e700 10 filestore(/tmp/cephtest/data/osd.5.data) setattrs 0.b_head/874f5bb/plana739334-37/head//0 = 213

on the primary, it did create it (snap collections went from 2,4 to 2,3), but either hte snaps vector didn't make it to the replica, or some other subtley prevented it from creating it..

this is probably related to #4051


Related issues

Related to Ceph - Bug #4051: osd: inconsistent snapcolls on argonaut Duplicate 02/07/2013

Associated revisions

Revision 54b6dd92 (diff)
Added by Sage Weil about 11 years ago

osd: unconditionally encode snaps buffer

Previously we would only encode the updated snaps vector for CLONE ops.
This doesn't work for MODIFY ops generated by the snap trimmer, which
may also adjust the clone collections. It is also possible that other
operations may need to populate this field in the future (e.g.,
LOST_REVERT may, although it currently does not).

Fixes: #4071, and possibly #4051.

Signed-off-by: Sage Weil <>
Reviewed-by: Samuel Just <>

Revision f0bf68ff (diff)
Added by Sage Weil about 11 years ago

osd: unconditionally encode snaps buffer

Previously we would only encode the updated snaps vector for CLONE ops.
This doesn't work for MODIFY ops generated by the snap trimmer, which
may also adjust the clone collections. It is also possible that other
operations may need to populate this field in the future (e.g.,
LOST_REVERT may, although it currently does not).

Fixes: #4071, and possibly #4051.

Signed-off-by: Sage Weil <>
Reviewed-by: Samuel Just <>
(cherry picked from commit 54b6dd924fea3af982f3d729150b6449f318daf2)

History

#1 Updated by Sage Weil about 11 years ago

  • Status changed from In Progress to Fix Under Review

wip-4071

#2 Updated by Sage Weil about 11 years ago

  • Backport set to bobtail, argonaut

#3 Updated by Sage Weil about 11 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF