Project

General

Profile

Bug #40679

cephfs-shell: TypeError in poutput

Added by Varsha Rao 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
Pull request ID:
Crash signature:

Description

Recent changes in signature of poutput method from cmd2 module causes the following error.

CephFS:~/>>> mkdir test
CephFS:~/>>> ls
poutput() takes 2 positional arguments but 3 were given
Traceback (most recent call last):
  File "../src/tools/cephfs/cephfs-shell", line 392, in onecmd
    res = Cmd.onecmd(self, line)
  File "/home/varsha/ceph/build/venv/lib/python3.7/site-packages/cmd2/cmd2.py", line 2145, in onecmd
    stop = func(statement)
  File "/home/varsha/ceph/build/venv/lib/python3.7/site-packages/cmd2/cmd2.py", line 286, in cmd_wrapper
    return func(cmd2_instance, args)
  File "../src/tools/cephfs/cephfs-shell", line 770, in do_ls
    print_list(values, shutil.get_terminal_size().columns)
  File "../src/tools/cephfs/cephfs-shell", line 239, in print_list
    end='\n' if i + nrows >= nwords else '')
  File "../src/tools/cephfs/cephfs-shell", line 58, in poutput
    shell.poutput(s, end)
TypeError: poutput() takes 2 positional arguments but 3 were given

[1] https://github.com/python-cmd2/cmd2/commit/4d2267322b7ac206692bc5ed8fa2ee0dd2ea5e26#diff-133db4f9f09695931a4c8e81676996beR590


Related issues

Copied to fs - Backport #40839: nautilus: cephfs-shell: TypeError in poutput Resolved

History

#1 Updated by Varsha Rao 4 months ago

  • Pull request ID set to 28906

#2 Updated by Varsha Rao 4 months ago

  • Status changed from New to Need Review

#3 Updated by Patrick Donnelly 4 months ago

  • Target version set to v15.0.0
  • Source set to Development

#4 Updated by Patrick Donnelly 4 months ago

  • Status changed from Need Review to Pending Backport

#5 Updated by Nathan Cutler 4 months ago

  • Copied to Backport #40839: nautilus: cephfs-shell: TypeError in poutput added

#6 Updated by Nathan Cutler 3 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF