Project

General

Profile

Cleanup #40578

mds: reorganize class members in headers to follow coding guidelines

Added by Patrick Donnelly 4 months ago. Updated 5 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Code Hygiene
Target version:
Start date:
10/07/2019
Due date:
% Done:

79%

Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
task(easy)
Pull request ID:

Description

Guide here: https://google.github.io/styleguide/cppguide.html#Declaration_Order

A past commit that has improved this: https://github.com/ceph/ceph/commit/36f3bc067f0971d490ab4aabe4feab2996138275

All of the MDS headers should follow these guidelines. This is especially helpful in identifying the public interface to a MDS class. Right now many MDS headers mix private/public in ways that makes understanding the class very difficult. For example:

https://github.com/ceph/ceph/blob/8ba339a41b2178cb27d4421bc512f3e622824d1d/src/mds/MDCache.h#L1108-L1130


Subtasks

Cleanup #40742: mds: reorg CDir headerResolvedVarsha Rao

Cleanup #40787: mds: reorg CInode headerResolvedVarsha Rao

Cleanup #40866: mds: reorg Capability headerResolvedVarsha Rao

Cleanup #41178: mds: reorg DamageTable headerResolvedVarsha Rao

Cleanup #41181: mds: reorg FSMap headerResolvedVarsha Rao

Cleanup #41185: mds: reorg FSMapUser headerResolvedVarsha Rao

Cleanup #41428: mds: reorg InoTable headerResolvedVarsha Rao

Cleanup #41430: mds: reorg JournalPointer headerResolvedVarsha Rao

Cleanup #41607: mds: reorg Anchor headerResolvedVarsha Rao

Bug #41654: mds: reorg LocalLock headerResolvedVarsha Rao

Cleanup #41665: mds: reorg Locker headerResolvedVarsha Rao

Cleanup #41678: mds: reorg LogSegment headerResolvedVarsha Rao

Cleanup #41679: mds: reorg LogEvent headerResolvedVarsha Rao

Cleanup #42043: mds: reorg MDBalancer headerResolvedVarsha Rao

Cleanup #42191: mds: reorg MDCache headerNeed ReviewVarsha Rao

Cleanup #42192: mds: reorg MDLog headerResolvedVarsha Rao

Cleanup #42311: mds: reorg MDSAuthCaps headerNeed ReviewVarsha Rao

Cleanup #42329: mds: reorg MDSCacheObject headerNeed ReviewVarsha Rao

Cleanup #42371: mds: reorg MDSDaemon headerNeed ReviewVarsha Rao

History

#1 Updated by Jos Collin 4 months ago

  • Pull request ID set to 28860

#2 Updated by Patrick Donnelly 4 months ago

  • Status changed from New to In Progress

#3 Updated by Patrick Donnelly 3 months ago

  • Tracker changed from Bug to Cleanup

Also available in: Atom PDF