Project

General

Profile

Actions

Bug #40487

closed

mgr/dashboard: clean-up python unit tests

Added by Ernesto Puerta almost 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
General
Target version:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently Python unit tests (actually doctests) bring in dependencies for other packages (rados, rbd, cephfs). Most of them aren't actually used at doctests, but cause ImportErrors.

By removing those dependencies, dashboard python unit-tests (240) now can be quickly run (<40 s) in python-only docker environments (e.g.: travis-ci, or CircleCI), without needing extra packages (python-rados, or RBD/CephFS python bindings).


Related issues 1 (1 open0 closed)

Blocks Dashboard - Feature #40296: mgr/dashboard: Maintain and improve code coverage on dashboard PRsIn ProgressStephan Müller

Actions
Actions #1

Updated by Ernesto Puerta almost 5 years ago

  • Pull request ID set to 28696
Actions #2

Updated by Stephan Müller over 4 years ago

  • Blocked by Feature #40296: mgr/dashboard: Maintain and improve code coverage on dashboard PRs added
Actions #3

Updated by Lenz Grimmer over 4 years ago

  • Status changed from In Progress to Fix Under Review
Actions #4

Updated by Ernesto Puerta over 4 years ago

  • Blocked by deleted (Feature #40296: mgr/dashboard: Maintain and improve code coverage on dashboard PRs)
Actions #5

Updated by Ernesto Puerta over 4 years ago

  • Blocks Feature #40296: mgr/dashboard: Maintain and improve code coverage on dashboard PRs added
Actions #6

Updated by Lenz Grimmer over 4 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.0.0
Actions #7

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 132 to General
Actions

Also available in: Atom PDF