Project

General

Profile

Bug #40476

cephfs-shell: cd with no args has no effect

Added by Rishabh Dave 5 months ago. Updated 4 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
Pull request ID:
Crash signature:

Description

Issuing cd command with no args implies "cd $HOME" in bash but on CephFS shell it has no effect it leads to an error -

CephFS:~/dir1/dir/dir3>>> cd 
usage: cd [-h] path
cd: error: the following arguments are required: path

I am not sure if that's what we want on CephFS shell too.


Related issues

Copied to fs - Backport #41112: nautilus: cephfs-shell: cd with no args has no effect In Progress

History

#1 Updated by Patrick Donnelly 5 months ago

  • Status changed from New to Need More Info
  • Start date deleted (06/21/2019)
  • Source set to Development

What commit/branch are you testing? I thought I just changed this to cd into the root directory (of CephFS).

#2 Updated by Jeff Layton 5 months ago

I'd consider this to be NOTABUG. We don't really have the concept of a home directory in cephfs shell, so why should this do anything? If we did want it to do something though then changing to the root probably makes as much sense as anything.

#3 Updated by Rishabh Dave 5 months ago

Patrick Donnelly said:

What commit/branch are you testing? I thought I just changed this to cd into the root directory (of CephFS).

master branch. Are you talking about PR #28663? While testing #28663 too I did come across this issue but judging from the commit message I did not feel that th
e commits there were trying to fix it.

I tried it today again and I can still reproduce this issue. Latest commit at the tip of my master is 9d1548bec41dd62793b452a1848dc67d29bb1797.

#4 Updated by Patrick Donnelly 5 months ago

Rishabh Dave wrote:

Patrick Donnelly said:

What commit/branch are you testing? I thought I just changed this to cd into the root directory (of CephFS).

master branch. Are you talking about PR #28663? While testing #28663 too I did come across this issue but judging from the commit message I did not feel that th
e commits there were trying to fix it.

I tried it today again and I can still reproduce this issue. Latest commit at the tip of my master is 9d1548bec41dd62793b452a1848dc67d29bb1797.

It may indeed be broken. It should by default use "/" but maybe the code doesn't work yet. Please make a test case in test_cephfs_shell.py along with a fix. The expected behavior of "cd" should be to chdir to /.

#5 Updated by Rishabh Dave 4 months ago

  • Pull request ID set to 28793

#6 Updated by Rishabh Dave 4 months ago

  • Status changed from Need More Info to Need Review

#7 Updated by Patrick Donnelly 4 months ago

  • Assignee set to Rishabh Dave
  • Target version set to v15.0.0
  • Backport set to nautilus

#8 Updated by Patrick Donnelly 4 months ago

  • Status changed from Need Review to Pending Backport

#9 Updated by Patrick Donnelly 3 months ago

  • Copied to Backport #41112: nautilus: cephfs-shell: cd with no args has no effect added

Also available in: Atom PDF