Bug #40418: cephfs-shell: test only python3 and assert python3 in cephfs-shell - CephFS - Ceph

Actions

Copy link

Bug #40418

closed

cephfs-shell: test only python3 and assert python3 in cephfs-shell

Added by Patrick Donnelly almost 5 years ago. Updated almost 5 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Patrick Donnelly

Category:

Target version:

Ceph - v15.0.0

% Done:

Source:

Development

Tags:

Backport:

nautilus

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

cephfs-shell, qa-suite

Labels (FS):

Pull request ID:

28638

Crash signature (v1):

Crash signature (v2):

Description

No reason to support python2 for this new tool. See this failure:

2019-06-18T12:36:07.670 INFO:teuthology.orchestra.run.smithi145:> cephfs-shell -c /etc/ceph/ceph.conf -- 'get p1'
2019-06-18T12:36:07.814 INFO:teuthology.orchestra.run.smithi145.stdout:'str' object has no attribute 'decode'
2019-06-18T12:36:07.814 INFO:teuthology.orchestra.run.smithi145.stdout:Traceback (most recent call last):
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 384, in onecmd
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:    res = Cmd.onecmd(self, line)
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/lib/python3/dist-packages/cmd2.py", line 964, in onecmd
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:    stop = func(statement)
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 40, in wrapper
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:    return func(thiz, args)
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 636, in do_get
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:    files = list(reversed(sorted(dirwalk(root_src_dir))))
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 312, in dirwalk
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:    fullpath = os.path.join(dir_name, item.d_name.decode('utf-8'))
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:AttributeError: 'str' object has no attribute 'decode'

From: /ceph/teuthology-archive/yuriw-2019-06-18_03:14:43-fs-wip-yuri-testing-2019-06-18-0112-nautilus-distro-basic-smithi/4044934/teuthology.log

Related issues 1 (0 open — 1 closed)