Project

General

Profile

Bug #40418

cephfs-shell: test only python3 and assert python3 in cephfs-shell

Added by Patrick Donnelly 2 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Urgent
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell, qa-suite
Labels (FS):
Pull request ID:

Description

No reason to support python2 for this new tool. See this failure:

2019-06-18T12:36:07.670 INFO:teuthology.orchestra.run.smithi145:> cephfs-shell -c /etc/ceph/ceph.conf -- 'get p1'
2019-06-18T12:36:07.814 INFO:teuthology.orchestra.run.smithi145.stdout:'str' object has no attribute 'decode'
2019-06-18T12:36:07.814 INFO:teuthology.orchestra.run.smithi145.stdout:Traceback (most recent call last):
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 384, in onecmd
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:    res = Cmd.onecmd(self, line)
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/lib/python3/dist-packages/cmd2.py", line 964, in onecmd
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:    stop = func(statement)
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 40, in wrapper
2019-06-18T12:36:07.815 INFO:teuthology.orchestra.run.smithi145.stdout:    return func(thiz, args)
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 636, in do_get
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:    files = list(reversed(sorted(dirwalk(root_src_dir))))
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:  File "/usr/bin/cephfs-shell", line 312, in dirwalk
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:    fullpath = os.path.join(dir_name, item.d_name.decode('utf-8'))
2019-06-18T12:36:07.816 INFO:teuthology.orchestra.run.smithi145.stdout:AttributeError: 'str' object has no attribute 'decode'

From: /ceph/teuthology-archive/yuriw-2019-06-18_03:14:43-fs-wip-yuri-testing-2019-06-18-0112-nautilus-distro-basic-smithi/4044934/teuthology.log


Related issues

Copied to fs - Backport #40469: nautilus: cephfs-shell: test only python3 and assert python3 in cephfs-shell Resolved

History

#1 Updated by Patrick Donnelly 2 months ago

  • Status changed from In Progress to Need Review
  • Pull request ID set to 28638

#2 Updated by Patrick Donnelly 2 months ago

  • Status changed from Need Review to Pending Backport

#3 Updated by Patrick Donnelly 2 months ago

  • Copied to Backport #40469: nautilus: cephfs-shell: test only python3 and assert python3 in cephfs-shell added

#4 Updated by Nathan Cutler 2 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF