Project

General

Profile

Bug #40399

mgr/dashboard: Reduce code duplication through TableActionComponent Unit Tests

Added by Patrick Seidensal 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
Start date:
06/17/2019
Due date:
% Done:

90%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

The test code for TableActionsComponent is reused at least 7 times across the modules which implement it. This results in duplicated code. With a refactoring, we could save at least 1000 lines of code in frontend unit tests.

History

#1 Updated by Patrick Seidensal 4 months ago

  • Subject changed from mgr/dashboard: Reduce code duplication in TableActionComponent Unit Tests to mgr/dashboard: Reduce code duplication through TableActionComponent Unit Tests

#2 Updated by Patrick Seidensal 4 months ago

  • Status changed from In Progress to Need Review
  • % Done changed from 0 to 90
  • Pull request ID set to 28633

#3 Updated by Ricardo Marques 3 months ago

  • Status changed from Need Review to Resolved
  • Target version set to v15.0.0

Also available in: Atom PDF