Bug #40245
filestore::read() does not assert on EIO
Status:
Won't Fix
Priority:
Normal
Assignee:
David Zafman
Category:
Correctness/Safety
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
nautilus mimic luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
FileStore
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
bufferptr bptr(len); // prealloc space for entire read got = safe_pread(**fd, bptr.c_str(), len, offset); if (got < 0) { dout(10) << __FUNC__ << ": (" << cid << "/" << oid << ") pread error: " << cpp_strerror(got) << dendl; lfn_close(fd); return got; }
Whoops!
History
#1 Updated by Greg Farnum almost 5 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 28478
#2 Updated by David Zafman almost 5 years ago
Maybe we should add a comment to the code there explaining why m_filestore_fail_eio is not checked and we always return the error.
#3 Updated by Greg Farnum almost 5 years ago
- Status changed from Fix Under Review to New
- Assignee changed from Greg Farnum to David Zafman
#4 Updated by Greg Farnum almost 5 years ago
Oh, this originated in the Red Hat tracker: https://bugzilla.redhat.com/show_bug.cgi?id=1682967
More discussion happening there; maybe we just won't worry about it since it's a LEVEL_DEV flag anyway.
#5 Updated by David Zafman over 4 years ago
- Status changed from New to Won't Fix