Project

General

Profile

Bug #39714

mgr/dashboard: Pool read/write OPS shows too many decimal places

Added by Patrick Seidensal over 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
Component - Pools
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

d67824d82b3ea3f630264b044ecbbe50.png View (11.6 KB) Patrick Seidensal, 05/13/2019 06:07 AM


Related issues

Duplicated by Dashboard - Bug #41345: mgr/dashboard: Read ops values should be rounded Resolved
Copied to Dashboard - Backport #44639: nautilus: mgr/dashboard: Pool read/write OPS shows too many decimal places Resolved

History

#1 Updated by Lenz Grimmer almost 3 years ago

  • Tags set to low-hanging-fruit, usability
  • Subject changed from mgr/dashboard: Pool read/write OPS shows to many decimal places to mgr/dashboard: Pool read/write OPS shows too many decimal places
  • Tags deleted (low-hanging-fruit)

#2 Updated by Stephan Müller almost 3 years ago

  • Duplicated by Bug #41345: mgr/dashboard: Read ops values should be rounded added

#3 Updated by anurag bandhu almost 3 years ago

I think Write-ops also need to be rounded off

#4 Updated by Stephan Müller almost 3 years ago

The thing is that the timestamps are 4 seconds apart by default, which results in an float at the end.

#5 Updated by Stephan Müller almost 3 years ago

I think the following should fix the problem:

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html
index c985616d3a..ceef88337a 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.html
@@ -254,7 +254,7 @@
 <ng-template #perSecondTpl
              let-row="row" 
              let-value="value">
-  {{ value }} /s
+  {{ value | dimless }} /s
 </ng-template>

 <ng-template #executingTpl

#6 Updated by anurag bandhu almost 3 years ago

yeah this is working

#7 Updated by anurag bandhu almost 3 years ago

  • Status changed from New to Pending Backport

#8 Updated by anurag bandhu almost 3 years ago

  • Backport set to nautilus

#9 Updated by anurag bandhu almost 3 years ago

  • Copied to Backport #44639: nautilus: mgr/dashboard: Pool read/write OPS shows too many decimal places added

#10 Updated by anurag bandhu almost 3 years ago

  • Pull request ID set to 33887

#11 Updated by Nathan Cutler almost 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

#12 Updated by Ernesto Puerta almost 2 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 137 to Component - Pools

Also available in: Atom PDF