Project

General

Profile

Bug #3952

krbd: no need for object header version

Added by Alex Elder about 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The header object watch operation had a sort of half implemented
use of the version of the object. It apparently is not needed,
so there's no need to keep track of it in the rbd kernel client.
Removing it can probably result in some additional cleanup of
the code.

History

#1 Updated by Alex Elder almost 11 years ago

  • Status changed from New to Fix Under Review

The following have been posted for review. They are
available in the "review/wip-rbd-cleanup-6" branch of
the ceph-client git repository.

As of this patch:
rbd: set up watch in rbd_dev_image_probe()
there is no longer any need to keep track of the
object version for an rbd header object. Getting
rid of it allows quite a bit of code to get
simplified, and the patches after the first in
this series do just that.

-Alex

[PATCH 1/5] rbd: stop tracking header object version
[PATCH 2/5] rbd: get rid of some version parameters
[PATCH 3/5] rbd: more version parameter removal
[PATCH 4/5] rbd: drop rbd_obj_method_sync() version parameter
[PATCH 5/5] rbd: drop obj_request->version

#2 Updated by Alex Elder almost 11 years ago

  • Status changed from Fix Under Review to Resolved

The following have been committed to the "testing"
branch of the ceph-client git repository:

7178711 rbd: stop tracking header object version
d854216 rbd: get rid of some version parameters
9e2fa4f rbd: more version parameter removal
cfd84d3 rbd: drop rbd_obj_method_sync() version parameter
8720099 rbd: drop obj_request->version

Also available in: Atom PDF