Project

General

Profile

Actions
Copy link

Bug #3933

closed

ceph-deploy gatherkeys silently fails if no host is specified

Added by Anonymous about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
ceph-deploy
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Actions
Copy link
 #1

Updated by Anonymous about 11 years ago

  • Category set to ceph-deploy

If no host is specified and ceph.conf exists gatherkeys will fail, but not report any error.

Actions
Copy link
 #2

Updated by Ian Colle about 11 years ago

  • Assignee set to Anonymous
Actions
Copy link
 #3

Updated by Ian Colle about 11 years ago

  • Priority changed from Normal to High
Actions
Copy link
 #4

Updated by Anonymous about 11 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Anonymous about 11 years ago

  • Status changed from In Progress to Fix Under Review

Fix is checked into wip-3933 branch.

Originally there was no output it a host was not supplied, but it is now:

ubuntu@gary-ubuntu-01:~/ceph-deploy$ ./ceph-deploy gatherkeys
WARNING:ceph_deploy.gatherkeys:Unable to find /etc/ceph/ceph.client.admin.keyring on []
DEBUG:ceph_deploy.gatherkeys:Have ceph.mon.keyring
WARNING:ceph_deploy.gatherkeys:Unable to find /var/lib/ceph/bootstrap-osd/ceph.keyring on []
WARNING:ceph_deploy.gatherkeys:Unable to find /var/lib/ceph/bootstrap-mds/ceph.keyring on []

With the fix to require at leas one arguement the result is:

ubuntu@gary-ubuntu-01:~/ceph-deploy$ ./ceph-deploy gatherkeys
usage: ceph-deploy gatherkeys [-h] HOST [HOST ...]
ceph-deploy gatherkeys: error: too few arguments

Actions
Copy link
 #6

Updated by Sage Weil about 11 years ago

  • Status changed from Fix Under Review to Resolved

commit:37d9abb4ba75b95a1d57febe290d8b5573e736bc

Actions
Copy link

Also available in: Atom PDF