Project

General

Profile

Bug #39281

object_stat_sum_t decode broken if given older version

Added by David Zafman 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature:

Description

When the encode/decode for object_stat_sum_t went from version 19 to 20 the fast path wasn't updated.

$ ceph-objectstore-tool --op dump-import --file 1.0.export
2019-04-12 09:46:30.901 7f51b46baa00 -1 WARNING: all dangerous and experimental features are enabled.
terminate called after throwing an instance of 'ceph::buffer::malformed_input'
  what():  buffer::malformed_input: void object_stat_sum_t::decode(ceph::buffer::v14_2_0::list::const_iterator&) decode past end of struct encoding
*** Caught signal (Aborted) **
 in thread 7f51b46baa00 thread_name:ceph-objectstor
 ceph version 15.0.0-257-g5fa9b0af82 (5fa9b0af82c87e7f80b7a78e59c0f0248c92f1c3) octopus (dev)
 1: (()+0x1fbbaa4) [0x55e5c2e94aa4]
 2: (()+0x12890) [0x7f51a8534890]
 3: (gsignal()+0xc7) [0x7f51a7628e97]
 4: (abort()+0x141) [0x7f51a762a801]
 5: (()+0x8c8b7) [0x7f51a801d8b7]
 6: (()+0x92a06) [0x7f51a8023a06]
 7: (()+0x92a41) [0x7f51a8023a41]
 8: (()+0x92c74) [0x7f51a8023c74]
 9: (object_stat_sum_t::decode(ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x88f) [0x55e5c29818c1]
 10: (decode(object_stat_sum_t&, ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x23) [0x55e5c29a5b84]
 11: (object_stat_collection_t::decode(ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x29d) [0x55e5c2982e73]
 12: (decode(object_stat_collection_t&, ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x23) [0x55e5c281528b]
 13: (pg_stat_t::decode(ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x3e2) [0x55e5c2984b1c]
 14: (decode(pg_stat_t&, ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x23) [0x55e5c25322f3]
 15: (pg_info_t::decode(ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x350) [0x55e5c298873a]
 16: (decode(pg_info_t&, ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x23) [0x55e5c2428322]
 17: (metadata_section::decode(ceph::buffer::v14_2_0::list::iterator_impl<true>&)+0x2a3) [0x55e5c24349a3]
 18: (dump_pg_metadata(ceph::Formatter*, ceph::buffer::v14_2_0::list&, metadata_section&)+0x4a) [0x55e5c2407711]
 19: (ObjectStoreTool::dump_import(ceph::Formatter*)+0x5c1) [0x55e5c2408709]
 20: (main()+0x27d3) [0x55e5c2416256]
 21: (__libc_start_main()+0xe7) [0x7f51a760bb97]
 22: (_start()+0x2a) [0x55e5c23fed5a]

Related issues

Copied to RADOS - Backport #39320: nautilus: object_stat_sum_t decode broken if given older version Resolved

History

#1 Updated by David Zafman 11 months ago

  • Status changed from New to In Progress
  • Pull request ID set to 27564

#2 Updated by Nathan Cutler 10 months ago

  • Backport set to nautilus

#3 Updated by Nathan Cutler 10 months ago

  • Status changed from In Progress to Pending Backport

#4 Updated by Nathan Cutler 10 months ago

  • Copied to Backport #39320: nautilus: object_stat_sum_t decode broken if given older version added

#5 Updated by Nathan Cutler 10 months ago

  • Status changed from Pending Backport to Fix Under Review

#6 Updated by Nathan Cutler 10 months ago

  • Status changed from Fix Under Review to Pending Backport

#7 Updated by Nathan Cutler 10 months ago

  • Status changed from Pending Backport to Resolved

#8 Updated by David Zafman 10 months ago

  • Status changed from Resolved to Pending Backport

#9 Updated by David Zafman 10 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF