Project

General

Profile

Fix #38953

mgr/dashboard: Fix the border radius of buttons/inputs

Added by Tiago Melo over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/usability
Target version:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

Currently we have buttons with a round border, but this rule is not being applied the same way to all the buttons.

As you can see in the following images in some cases you get the right buttons in an input with round border and in other not.
I also don't like to have round and squared border mixed in the same form.

I would suggest doing one of the following:
  • Remove all the round borders (my preferred option)
  • Apply round borders to all buttons and inputs
  • Apply round borders only to isolated buttons, keeping the borders squared in buttons that are inside input-groups

1.png View (108 KB) Tiago Melo, 03/27/2019 03:51 PM

2.png View (88.3 KB) Tiago Melo, 03/27/2019 03:51 PM

History

#1 Updated by Laura Paduano over 1 year ago

Tiago Melo wrote:

Currently we have buttons with a round border, but this rule is not being applied the same way to all the buttons.

As you can see in the following images in some cases you get the right buttons in an input with round border and in other not.
I also don't like to have round and squared border mixed in the same form.

I would suggest doing one of the following:
  • Remove all the round borders (my preferred option)
  • Apply round borders to all buttons and inputs
  • Apply round borders only to isolated buttons, keeping the borders squared in buttons that are inside input-groups

I would be in favor of option 1 (remove all round borders) or option 3 (apply round borders only to isolated buttons).

#2 Updated by Tiago Melo about 1 year ago

  • Status changed from New to 12
  • Assignee set to Tiago Melo

During the F2F we decided to use square borders.

#3 Updated by Lenz Grimmer about 1 year ago

  • Tags set to low-hanging-fruit, usability

#4 Updated by Tiago Melo about 1 year ago

  • Status changed from 12 to Fix Under Review
  • Pull request ID set to 29001

#5 Updated by Tiago Melo about 1 year ago

  • Status changed from Fix Under Review to Resolved

#6 Updated by Ricardo Marques about 1 year ago

  • Target version set to v15.0.0

Also available in: Atom PDF