Project

General

Profile

Actions
Copy link

Bug #38953

closed

mgr/dashboard: Fix the border radius of buttons/inputs

Added by Tiago Melo about 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Tiago Melo
Category:
UX
Target version:
Ceph - v15.0.0
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
29001
Crash signature (v1):
Crash signature (v2):

Description

Currently we have buttons with a round border, but this rule is not being applied the same way to all the buttons.

As you can see in the following images in some cases you get the right buttons in an input with round border and in other not.
I also don't like to have round and squared border mixed in the same form.

I would suggest doing one of the following:
  • Remove all the round borders (my preferred option)
  • Apply round borders to all buttons and inputs
  • Apply round borders only to isolated buttons, keeping the borders squared in buttons that are inside input-groups

Files

Download all files
1.png (108 KB) 1.png Tiago Melo, 03/27/2019 03:51 PM
2.png (88.3 KB) 2.png Tiago Melo, 03/27/2019 03:51 PM
Actions
Copy link
 #1

Updated by Laura Paduano about 5 years ago

Tiago Melo wrote:

Currently we have buttons with a round border, but this rule is not being applied the same way to all the buttons.

As you can see in the following images in some cases you get the right buttons in an input with round border and in other not.
I also don't like to have round and squared border mixed in the same form.

I would suggest doing one of the following:
  • Remove all the round borders (my preferred option)
  • Apply round borders to all buttons and inputs
  • Apply round borders only to isolated buttons, keeping the borders squared in buttons that are inside input-groups

I would be in favor of option 1 (remove all round borders) or option 3 (apply round borders only to isolated buttons).

Actions
Copy link
 #2

Updated by Tiago Melo almost 5 years ago

  • Status changed from New to 12
  • Assignee set to Tiago Melo

During the F2F we decided to use square borders.

Actions
Copy link
 #3

Updated by Lenz Grimmer almost 5 years ago

  • Translation missing: en.field_tag_list set to low-hanging-fruit, usability
Actions
Copy link
 #4

Updated by Tiago Melo almost 5 years ago

  • Status changed from 12 to Fix Under Review
  • Pull request ID set to 29001
Actions
Copy link
 #5

Updated by Tiago Melo almost 5 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #6

Updated by Ricardo Marques almost 5 years ago

  • Target version set to v15.0.0
Actions
Copy link
 #7

Updated by Ernesto Puerta about 3 years ago

  • Tracker changed from Fix to Bug
  • Project changed from mgr to Dashboard
  • Category changed from 152 to UX
  • Regression set to No
  • Severity set to 3 - minor
Actions
Copy link

Also available in: Atom PDF