Project

General

Profile

Bug #38899

mgr: handle_conf_change - broken locking

Added by xie xingguo 8 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
nautilus,mimic,luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

The is_locked_by_me() is only meant to be safe if you know you hold the lock. It's meant to be used in an assertion.


Related issues

Copied to Ceph - Backport #38962: luminous: DaemonServer::handle_conf_change - broken locking Resolved
Copied to Ceph - Backport #38963: mimic: DaemonServer::handle_conf_change - broken locking Resolved
Copied to Ceph - Backport #38964: nautilus: DaemonServer::handle_conf_change - broken locking Resolved

History

#1 Updated by Mykola Golub 8 months ago

  • Pull request ID set to 27144

#2 Updated by Mykola Golub 8 months ago

  • Status changed from New to Need Review

#3 Updated by xie xingguo 8 months ago

  • Pull request ID changed from 27144 to 27184

#4 Updated by Sage Weil 8 months ago

  • Status changed from Need Review to Pending Backport
  • Backport set to nautilus, mimic, luminous

#5 Updated by Nathan Cutler 8 months ago

  • Copied to Backport #38962: luminous: DaemonServer::handle_conf_change - broken locking added

#6 Updated by Nathan Cutler 8 months ago

  • Copied to Backport #38963: mimic: DaemonServer::handle_conf_change - broken locking added

#7 Updated by Nathan Cutler 8 months ago

  • Copied to Backport #38964: nautilus: DaemonServer::handle_conf_change - broken locking added

#8 Updated by Patrick Donnelly 8 months ago

  • Project changed from Ceph to mgr
  • Subject changed from DaemonServer::handle_conf_change - broken locking to mgr: handle_conf_change - broken locking
  • Target version set to v15.0.0
  • Start date deleted (03/23/2019)
  • Backport changed from nautilus, mimic, luminous to nautilus,mimic,luminous
  • Affected Versions deleted (v15.0.0)

#9 Updated by Nathan Cutler 3 months ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved".

Also available in: Atom PDF