Bug #38636: Inline data compatibly check in Locker::issue_caps is buggy - CephFS - Ceph

Actions

Copy link

Bug #38636

closed

Inline data compatibly check in Locker::issue_caps is buggy

Added by Zheng Yan about 5 years ago. Updated about 5 years ago.

Status:

Duplicate

Priority:

Normal

Assignee:

Category:

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Labels (FS):

Pull request ID:

26881

Crash signature (v1):

Crash signature (v2):

Description

    Session *session = mds->get_session(it->first);
    if (in->inode.inline_data.version != CEPH_INLINE_NONE &&
        !(session &&
          session->get_connection() &&
          session->get_connection()->has_feature(CEPH_FEATURE_MDS_INLINE_DATA)))
      allowed &= ~(CEPH_CAP_FILE_RD | CEPH_CAP_FILE_WR);

Session->get_connection() can be null for imported session. No idea how to fix this (luminous, mimic also need fix) unless obsolete inline data feature

Related issues 1 (0 open — 1 closed)