Actions
Bug #38627
closedinsights is not Python 3 compatible
% Done:
0%
Source:
Community (dev)
Tags:
QA
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
/src/scripts/run_mypy.sh
revealed some type errors in the insights module:
pybind/mgr/insights/module.py: note: In member "do_prune_health" of class "Module": pybind/mgr/insights/module.py:298: error: Name 'errno' is not defined pybind/mgr/insights/module.py: note: In member "testing_set_now_time_offset" of class "Module": pybind/mgr/insights/module.py:310: error: Name 'long' is not defined pybind/mgr/insights/module.py: note: In member "handle_command" of class "Module": pybind/mgr/insights/module.py:320: error: Name 'cmd' is not defined
Especially "Name 'long' is not defined" looks like a Python 3 incompatibility
Updated by Kefu Chai almost 5 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 27925
Updated by Kefu Chai almost 5 years ago
- Pull request ID changed from 27925 to 27926
Updated by Kefu Chai almost 5 years ago
- Status changed from Fix Under Review to Resolved
Actions