Project

General

Profile

Bug #38625

diskprediction_cloud has some type errors

Added by Sebastian Wagner 7 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
diskprediction_cloud
Target version:
-
Start date:
03/07/2019
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
QA
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

src/scripts/run_mypy.sh revealed some real type errors:

pybind/mgr/diskprediction_cloud/common/client_pb2.py:1394: error: "GeneratedProtocolMessageType" has no attribute "MapValueEntry" 
pybind/mgr/diskprediction_cloud/common/client_pb2.py:1409: error: "GeneratedProtocolMessageType" has no attribute "PhoneNumber" 
pybind/mgr/diskprediction_cloud/common/client_pb2.py:1424: error: "GeneratedProtocolMessageType" has no attribute "File" 
pybind/mgr/diskprediction_cloud/common/client_pb2.py:1561: error: "Descriptor" has no attribute "_options" 
pybind/mgr/diskprediction_cloud/common/grpcclient.py:110: error: Name 'long' is not defined
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py: note: In member "_collect_data" of class "SAIDiskSmartAgent":
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:69: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:70: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:71: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:72: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:73: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:74: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:75: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:76: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:77: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:78: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:79: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:80: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:81: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:82: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:83: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:89: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:91: error: Unsupported target for indexed assignment
pybind/mgr/diskprediction_cloud/agent/metrics/sai_disk_smart.py:179: error: Incompatible types in assignment (expression has type "float", variable has type "None")

those look like real errors. Some of them my be false positives, but each of them has to be investigated.

Also available in: Atom PDF