Project

General

Profile

Actions
Copy link

Bug #38504

closed

librbd: Qos fix bug in were_all_throttled()

Added by Yang Dongsheng about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

were_all_throttled() function is not correct: 

bool were_all_throttled() {
       return m_throttled_flag & RBD_QOS_MASK;
   }

but we want is :
bool were_all_throttled() {
return (m_throttled_flag & RBD_QOS_MASK) == RBD_QOS_MASK;
}

Actions
Copy link
 #2

Updated by Jason Dillaman about 5 years ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #3

Updated by Jason Dillaman about 5 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF