Project

General

Profile

Bug #38504

librbd: Qos fix bug in were_all_throttled()

Added by Yang Dongsheng 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
02/28/2019
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

were_all_throttled() function is not correct:

bool were_all_throttled() {
return m_throttled_flag & RBD_QOS_MASK;
}

but we want is :
bool were_all_throttled() {
return (m_throttled_flag & RBD_QOS_MASK) == RBD_QOS_MASK;
}

History

#2 Updated by Jason Dillaman 6 months ago

  • Status changed from New to Need Review

#3 Updated by Jason Dillaman 6 months ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF