Project

General

Profile

Actions
Copy link

Backport #38450

closed

mimic: src/osd/OSDMap.h: 1065: FAILED assert(__null != pool)

Added by Nathan Cutler about 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Target version:
Ceph - v13.2.7
Release:
mimic
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/29976

Related issues 1 (0 open — 1 closed)

Copied from RADOS - Bug #26970: src/osd/OSDMap.h: 1065: FAILED assert(__null != pool)Resolved08/20/2018

Actions
Actions
Copy link
 #1

Updated by Nathan Cutler about 5 years ago

  • Copied from Bug #26970: src/osd/OSDMap.h: 1065: FAILED assert(__null != pool) added
Actions
Copy link
 #2

Updated by Nathan Cutler about 5 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee set to Nathan Cutler
Actions
Copy link
 #3

Updated by Nathan Cutler over 4 years ago

  • Description updated (diff)
  • Status changed from In Progress to Need More Info
  • Assignee deleted (Nathan Cutler)

A naive backport - https://github.com/ceph/ceph/pull/26594 - was closed because it resulted in the following build failure:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc: In member function 'bool OSD::project_pg_history(spg_t, pg_history_t&, epoch_t, const OSDMap&, const std::vector<int>&, int, const std::vector<int>&, int)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4218:51: error: base operand of '->' has non-pointer type 'const OSDMap'
            << " from " << from << " to " << endmap->get_epoch()
                                                   ^~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4223:18: error: base operand of '->' has non-pointer type 'const OSDMap'
   for (e = endmap->get_epoch();
                  ^~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4258:15: error: base operand of '->' has non-pointer type 'const OSDMap'
         endmap->get_pg_num(pgid.pool()),
               ^~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc: In member function 'void OSD::handle_pg_query_nopg(const MQuery&)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:8612:43: error: no matching function for call to 'OSD::project_pg_history(spg_t&, pg_history_t&, const epoch_t&, OSDMapRef&, std::vector<int>&, int&, std::vector<int>&, int&)'
     up, up_primary, acting, acting_primary);
                                           ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4210:6: note: candidate: bool OSD::project_pg_history(spg_t, pg_history_t&, epoch_t, const OSDMap&, const std::vector<int>&, int, const std::vector<int>&, int)
 bool OSD::project_pg_history(spg_t pgid, pg_history_t& h, epoch_t from,
      ^~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.cc:4210:6: note:   no known conversion for argument 4 from 'OSDMapRef {aka std::shared_ptr<const OSDMap>}' to 'const OSDMap&'
src/osd/CMakeFiles/osd.dir/build.make:62: recipe for target 'src/osd/CMakeFiles/osd.dir/OSD.cc.o' failed
make[3]: *** [src/osd/CMakeFiles/osd.dir/OSD.cc.o] Error 1
Actions
Copy link
 #4

Updated by David Zafman over 4 years ago

  • Assignee set to David Zafman
Actions
Copy link
 #5

Updated by David Zafman over 4 years ago

  • Description updated (diff)
  • Status changed from Need More Info to In Progress
Actions
Copy link
 #6

Updated by Yuri Weinstein over 4 years ago

Nathan Cutler wrote:

https://github.com/ceph/ceph/pull/29976

merged

Actions
Copy link
 #7

Updated by David Zafman over 4 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #8

Updated by Nathan Cutler over 4 years ago

  • Target version set to v13.2.7

This update was made using the script "backport-resolve-issue".
backport PR https://github.com/ceph/ceph/pull/29976
merge commit fd5d0036b4924a6961805231c01db392355ea494 (v13.2.6-450-gfd5d0036b49)

Actions
Copy link

Also available in: Atom PDF