Project

General

Profile

Cleanup #37941

mgr/dashboard: Replace IP address validation with Python standard library functions

Added by Patrick Seidensal 10 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/general
Target version:
Start date:
01/16/2019
Due date:
% Done:

0%

Tags:
low-hanging-fruit
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently, we use self-written validation methods to validate IPv4 and IPv6 addresses. By replacing those with Pythons standard library functions, namely `ipaddress`, we can save around 40 lines of code (including tests) and reduce the complexity of the code.

https://docs.python.org/3/library/ipaddress.html

History

#1 Updated by Lenz Grimmer 10 months ago

  • Status changed from New to Need Review
  • Pull request ID set to 26184

#2 Updated by Ashish Singh 9 months ago

  • Assignee set to Ashish Singh

#3 Updated by Sage Weil 7 months ago

  • Status changed from Need Review to Resolved

#4 Updated by Lenz Grimmer 7 months ago

  • Target version set to v15.0.0

Also available in: Atom PDF