Project

General

Profile

Actions
Copy link

Cleanup #37941

closed

mgr/dashboard: Replace IP address validation with Python standard library functions

Added by Patrick Seidensal over 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ashish Singh
Category:
General
Target version:
Ceph - v15.0.0
% Done:

0%

Tags:
low-hanging-fruit
Backport:
Reviewed:
Affected Versions:
Pull request ID:
26184

Description

Currently, we use self-written validation methods to validate IPv4 and IPv6 addresses. By replacing those with Pythons standard library functions, namely `ipaddress`, we can save around 40 lines of code (including tests) and reduce the complexity of the code.

https://docs.python.org/3/library/ipaddress.html

Actions
Copy link
 #1

Updated by Lenz Grimmer about 5 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 26184
Actions
Copy link
 #2

Updated by Ashish Singh about 5 years ago

  • Assignee set to Ashish Singh
Actions
Copy link
 #3

Updated by Sage Weil almost 5 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #4

Updated by Lenz Grimmer almost 5 years ago

  • Target version set to v15.0.0
Actions
Copy link
 #5

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 132 to General
Actions
Copy link

Also available in: Atom PDF