Project

General

Profile

Bug #37533

diskprediction_cloud plugin requirements.txt asks for unused "google==2.0.1"

Added by Dan Mick 9 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
diskprediction_cloud
Target version:
-
Start date:
12/05/2018
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

after installing all of requirements.txt and searching for "googlesearch", the only hits are on files in the package itself

(there's no Ubuntu distro-packaged version of this package)

History

#1 Updated by Rick Chen 9 months ago

Dan Mick wrote:

after installing all of requirements.txt and searching for "googlesearch", the only hits are on files in the package itself

(there's no Ubuntu distro-packaged version of this package)

Can you provide your operation system version?
That help me to reproduce it and solve it, Thanks.

#2 Updated by Dan Mick 9 months ago

This has little to do with operating system, does it? Aren't pip and pypi independent of OS, at least for .py files?

#3 Updated by Rick Chen 9 months ago

Dan Mick wrote:

This has little to do with operating system, does it? Aren't pip and pypi independent of OS, at least for .py files?

Yes. This plugin need grpc library. User need install dependence library.

#4 Updated by Dan Mick 9 months ago

What is "dependence library"? Surely grpc is provided by

grpc==0.3.post19
grpc-google-logging-v2==0.8.1
grpc-google-pubsub-v1==0.8.1
grpcio==1.14.1

#5 Updated by Rick Chen 9 months ago

Dan Mick wrote:

What is "dependence library"? Surely grpc is provided by

grpc==0.3.post19
grpc-google-logging-v2==0.8.1
grpc-google-pubsub-v1==0.8.1
grpcio==1.14.1

That also needs google.protobuf and google.api library. These library use pip install it.

#6 Updated by Dan Mick 9 months ago

Let me say this again slowly:

the line "google==2.0.1" in requirements.txt installs a Python package named "googlesearch".

Here is the "RECORD" file from its distinfo directory:

$ cat google-2.0.1.dist-info/RECORD
../../../bin/google,sha256=8NtNzapQpc_NepEBptelbDOcXNWH5GTDQQmuvGXaVXk,4437
google-2.0.1.dist-info/INSTALLER,sha256=zuuue4knoyJ-UwPPXg8fezS7VCrXJQrAP7zeNuwvFQg,4
google-2.0.1.dist-info/METADATA,sha256=MiZdH_TthIFM4FCVYtGFQDRTdCGjHnTe0ald3JjQcsE,742
google-2.0.1.dist-info/RECORD,,
google-2.0.1.dist-info/WHEEL,sha256=_wJFdOYk7i3xxT8ElOkUJvOdOvfNGbR9g-bf6UQT6sU,110
google-2.0.1.dist-info/top_level.txt,sha256=QwrZIp2fe23UtbZ72VzI-n8e4tkCJ7zuT5dK5z84Nws,13
googlesearch/__init__.py,sha256=U5DZD-v12krwSBlscKxDyPrIh50g9oMmWAZNR1XwKuE,18106
googlesearch/__init__.pyc,,

It only has "googlesearch/__init__.py" and "bin/google" in it. Neither of those supply any packages named "google.<anything>".

What do you claim is using the googlesearch package?

#7 Updated by Rick Chen 9 months ago

Thanks, I got it.
I create PR for this issue.
https://github.com/ceph/ceph/pull/25433

#8 Updated by Brad Hubbard 9 months ago

  • Project changed from Ceph to mgr

#9 Updated by Dan Mick 9 months ago

  • Category set to diskprediction_cloud
  • Status changed from New to Testing

#10 Updated by Sebastian Wagner 4 months ago

  • Status changed from Testing to Resolved
  • Pull request ID set to 25433

Also available in: Atom PDF