Project

General

Profile

Actions
Copy link

Bug #3751

closed

krbd: fix type of snap_id local variable

Added by Alex Elder over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Alex Elder
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

The type of the snap_id local variable in rbd_dev_v2_snap_info()
is defined with the wrong byte order.

Actions
Copy link
 #1

Updated by Alex Elder over 11 years ago

I have a fix for this and I'll post it for review later
today.


Index: b/drivers/block/rbd.c
===================================================================
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -2800,7 +2800,7 @@ out:
 static char *rbd_dev_v2_snap_info(struct rbd_device *rbd_dev, u32 which,
                u64 *snap_size, u64 *snap_features)
 {
-       __le64 snap_id;
+       u64 snap_id;
        u8 order;
        int ret;
Actions
Copy link
 #2

Updated by Alex Elder over 11 years ago

  • Status changed from New to Resolved
This fix has been reviewed and committed to the testing branch.
    rbd: fix type of snap_id in rbd_dev_v2_snap_info()
Its current commit id (likely to change) is e0b49868d.
Actions
Copy link

Also available in: Atom PDF