Project

General

Profile

Feature #37086

Add several flags to ceph-volume lvm batch

Added by Jan Fajerski over 1 year ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
mimic, nautilus
Reviewed:
Affected Versions:
Pull request ID:

Description

as discussed in several orchestrator meetings, the batch subcommand needs several arg additions.

-replace-osd-ids=previous_osd_ids  # comma separated list. See notes below

--objectstore={filestore,bluestore}

--dmcrypt

--osds-per-device <N>

--shared-device <dev>  # for hybrid osds, db or journal

--num-slots <N>   # if we want to divide shared device by N > num devices

--shared-underprovision-ratio <ratio>


Related issues

Copied to ceph-volume - Backport #40919: mimic: Add several flags to ceph-volume lvm batch Resolved
Copied to ceph-volume - Backport #40954: nautilus: Add several flags to ceph-volume lvm batch Rejected

History

#1 Updated by Alfredo Deza over 1 year ago

--dmcrypt, --objectstore, and --osds-per-device are already supported

I don't think that --num-slots or --shared-underprovision are needed since we support --journal-size and --block-db-size, that can be set to whatever number so that shared devices can be
underutilized

#2 Updated by Jan Fajerski about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Jan Fajerski

I had a look into the batch subcommand. The current argument stucture (with data devices as positional arguments and --bluestore/--filestore as optional) it's not possible to add arguments like --wal-devices while keeping existing functionality as is.
I decided to add an optional subcommand objectstore. By default this is empty and results in batch behaving like it does today. Otherwise it can either be bluestore or filestore. This allows for new functionality being implemented without impacting existing users, as well as for proper separation between bluestore-only and filestore-only arguments.
The development branch is here https://github.com/jan--f/ceph/tree/c-v-extend-batch

#3 Updated by Dan van der Ster 12 months ago

AFAICT this was merged into master. Do you plan backports into mimic and luminous?

#4 Updated by Jan Fajerski 12 months ago

I believe so. I'm happy to provide the PRs, though its ultimately up to Andrew Schoen when those will land.

#5 Updated by Nathan Cutler 12 months ago

@Jan: Provide the master PR ID number as well?

#6 Updated by Jan Fajerski 12 months ago

Nathan Cutler wrote:

@Jan: Provide the master PR ID number as well?

https://github.com/ceph/ceph/pull/25542

There is some more backporting work to be done though.

#7 Updated by Jan Fajerski 7 months ago

  • Copied to Backport #40919: mimic: Add several flags to ceph-volume lvm batch added

#8 Updated by Nathan Cutler 7 months ago

  • Pull request ID set to 25542

#9 Updated by Nathan Cutler 7 months ago

  • Status changed from In Progress to Pending Backport

#10 Updated by Nathan Cutler 7 months ago

  • Backport set to mimic, nautilus

#11 Updated by Nathan Cutler 7 months ago

  • Copied to Backport #40954: nautilus: Add several flags to ceph-volume lvm batch added

#12 Updated by Nathan Cutler 6 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF