Bug #36708: mgr/dashboard: backend api tests: tasks.mgr.dashboard.test_osd.OsdTest failures - Dashboard - Ceph

Actions

Copy link

Bug #36708

closed

mgr/dashboard: backend api tests: tasks.mgr.dashboard.test_osd.OsdTest failures

Added by Laura Paduano over 5 years ago. Updated about 3 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Volker Theile

Category:

Testing & QA

Target version:

% Done:

Source:

Q/A

Tags:

Backport:

Regression:

Yes

Severity:

3 - minor

Reviewed:

Affected Versions:

Ceph - v14.0.0

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

Currently the dashboard backend api tests fail (when running the QA tests in sepia lab as well as when executing the run-backend-api-tests.sh locally) with:

2018-11-06 08:11:08,969.969 INFO:__main__:FAIL: test_create_lost_destroy_remove (tasks.mgr.dashboard.test_osd.OsdTest)
2018-11-06 08:11:08,969.969 INFO:__main__:----------------------------------------------------------------------
2018-11-06 08:11:08,969.969 INFO:__main__:Traceback (most recent call last):
2018-11-06 08:11:08,969.969 INFO:__main__:  File "/ceph/qa/tasks/mgr/dashboard/test_osd.py", line 92, in test_create_lost_destroy_remove
2018-11-06 08:11:08,969.969 INFO:__main__:    self.assertStatus(200)
2018-11-06 08:11:08,969.969 INFO:__main__:  File "/ceph/qa/tasks/mgr/dashboard/helper.py", line 342, in assertStatus
2018-11-06 08:11:08,969.969 INFO:__main__:    self.assertEqual(self._resp.status_code, status)
2018-11-06 08:11:08,970.970 INFO:__main__:AssertionError: 400 != 200
2018-11-06 08:11:08,970.970 INFO:__main__:
2018-11-06 08:11:08,970.970 INFO:__main__:----------------------------------------------------------------------
2018-11-06 08:11:08,970.970 INFO:__main__:Ran 37 tests in 453.681s
2018-11-06 08:11:08,970.970 INFO:__main__:
2018-11-06 08:11:08,971.971 INFO:__main__:FAILED (failures=1, skipped=1)
2018-11-06 08:11:08,971.971 INFO:__main__:
2018-11-06 08:11:08,971.971 INFO:__main__:======================================================================
2018-11-06 08:11:08,971.971 INFO:__main__:FAIL: test_create_lost_destroy_remove (tasks.mgr.dashboard.test_osd.OsdTest)
2018-11-06 08:11:08,971.971 INFO:__main__:----------------------------------------------------------------------
2018-11-06 08:11:08,971.971 INFO:__main__:Traceback (most recent call last):
2018-11-06 08:11:08,972.972 INFO:__main__:  File "/ceph/qa/tasks/mgr/dashboard/test_osd.py", line 92, in test_create_lost_destroy_remove
2018-11-06 08:11:08,972.972 INFO:__main__:    self.assertStatus(200)
2018-11-06 08:11:08,972.972 INFO:__main__:  File "/ceph/qa/tasks/mgr/dashboard/helper.py", line 342, in assertStatus
2018-11-06 08:11:08,972.972 INFO:__main__:    self.assertEqual(self._resp.status_code, status)
2018-11-06 08:11:08,972.972 INFO:__main__:AssertionError: 400 != 200

Files

id_param_no_int.png (218 KB) id_param_no_int.png

Volker Theile, 11/07/2018 09:58 AM

Actions

Copy link

Updated by Patrick Seidensal over 5 years ago

Status changed from New to In Progress
Assignee set to Patrick Seidensal

Actions

Copy link

Updated by Patrick Seidensal over 5 years ago

Assignee changed from Patrick Seidensal to Volker Theile
Regression changed from No to Yes

Reproducible by making a POST request to `api/osd` with a JSON body containing `uuid` and `svc_id`. Both parameters aren't passed to the `create` method anymore. Regression introduced by https://github.com/ceph/ceph/pull/24475.

Actions

Copy link

Updated by Patrick Seidensal over 5 years ago

Status changed from In Progress to 12

Actions

Copy link

Updated by Volker Theile over 5 years ago

Subject changed from dashboard backend api tests: tasks.mgr.dashboard.test_osd.OsdTest failures to mgr/dashboard: backend api tests: tasks.mgr.dashboard.test_osd.OsdTest failures

Actions

Copy link

Updated by Volker Theile over 5 years ago

Status changed from 12 to Fix Under Review

https://github.com/ceph/ceph/pull/24947

Actions

Copy link

Updated by Volker Theile over 5 years ago

Had to do some research what exactly is the problem: Our unit test framework or a Cherrypy tool plugin. The API Audit PR (#24475) introduces the usage of the CherryPy json_in plugin. It is responsible to decode the JSON body data. It seems our unit testing framework is submitting the 'application/json' header either nor JSON data is in the body. I don't know if this is correct, so the problem might be on the unit testing framework or the CherryPy plugin is too lax in validating the body before it tries to decode non-existing JSON data.
See https://github.com/cherrypy/cherrypy/blob/master/cherrypy/lib/jsontools.py#L13 for the point of problem.

If it is incorrect to submit the header then our old code simply ignores and catches an error of our unit test and CherryPy is doing the right job.

It comes out that our unit test framework did it wrong:
https://github.com/ceph/ceph/blob/2f5e7c33925c51c56b074453c50c4286375333eb/qa/tasks/mgr/dashboard/helper.py#L167
The application type header is normally set by the requests library if there is valid JSON data that is submitted in the request body:
https://github.com/requests/requests/blob/master/requests/models.py#L462

Actions

Copy link

Updated by Volker Theile over 5 years ago

File id_param_no_int.png id_param_no_int.png added

Actions

Copy link

Updated by Volker Theile over 5 years ago

The https://github.com/ceph/ceph/pull/24947 PR also fixes a problem that comes out while debugging. The svc_id parameter in the create() method of the OSD controller is not converted into an integer if it was submitted as a string (e.g. when application type is 'x-www-form-urlencoded').

Actions

Copy link