Bug #36677
/usr/include/rados/buffer.h:657:61: error: expected ',' before ')' token
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
2018-11-01T19:44:21.759 INFO:tasks.workunit.client.0.smithi040.stdout:g++ -std=c++11 -Wno-unused-parameter -Wall -Wextra -Werror -g -o hello_world_cpp hello_world.cc -lrados -lradosstriper 2018-11-01T19:44:22.149 INFO:tasks.workunit.client.0.smithi040.stderr:In file included from /usr/include/rados/librados.hpp:11:0, 2018-11-01T19:44:22.149 INFO:tasks.workunit.client.0.smithi040.stderr: from hello_world.cc:14: 2018-11-01T19:44:22.149 INFO:tasks.workunit.client.0.smithi040.stderr:/usr/include/rados/buffer.h:657:61: error: expected ‘,’ before ‘)’ token 2018-11-01T19:44:22.149 INFO:tasks.workunit.client.0.smithi040.stderr: static_assert(sizeof(contiguous_filler) == sizeof(char*)); 2018-11-01T19:44:22.149 INFO:tasks.workunit.client.0.smithi040.stderr: ^ 2018-11-01T19:44:22.149 INFO:tasks.workunit.client.0.smithi040.stderr:/usr/include/rados/buffer.h:657:61: error: expected string-literal before ‘)’ token 2018-11-01T19:44:22.225 INFO:tasks.workunit.client.0.smithi040.stderr:make: *** [hello_world_cpp] Error 1 2018-11-01T19:44:22.225 INFO:tasks.workunit.client.0.smithi040.stderr:+ cleanup 2018-11-01T19:44:22.225 INFO:tasks.workunit.client.0.smithi040.stderr:+ for f in '$BINARIES$SOURCES' 2018-11-01T19:44:22.226 INFO:tasks.workunit.client.0.smithi040.stderr:+ rm -f /home/ubuntu/cephtest/mnt.0/client.0/tmp/hello_world_c 2018-11-01T19:44:22.226 INFO:tasks.workunit.client.0.smithi040.stderr:+ for f in '$BINARIES$SOURCES' 2018-11-01T19:44:22.227 INFO:tasks.workunit.client.0.smithi040.stderr:+ rm -f /home/ubuntu/cephtest/mnt.0/client.0/tmp/hello_world_cpp 2018-11-01T19:44:22.228 INFO:tasks.workunit.client.0.smithi040.stderr:+ for f in '$BINARIES$SOURCES' 2018-11-01T19:44:22.228 INFO:tasks.workunit.client.0.smithi040.stderr:+ rm -f /home/ubuntu/cephtest/mnt.0/client.0/tmp/hello_radosstriper_cpp 2018-11-01T19:44:22.229 INFO:tasks.workunit.client.0.smithi040.stderr:+ for f in '$BINARIES$SOURCES' 2018-11-01T19:44:22.230 INFO:tasks.workunit.client.0.smithi040.stderr:+ rm -f /home/ubuntu/cephtest/mnt.0/client.0/tmp/hello_radosstriper.cc 2018-11-01T19:44:22.230 INFO:tasks.workunit.client.0.smithi040.stderr:+ for f in '$BINARIES$SOURCES' 2018-11-01T19:44:22.230 INFO:tasks.workunit.client.0.smithi040.stderr:+ rm -f /home/ubuntu/cephtest/mnt.0/client.0/tmp/hello_world_c.c 2018-11-01T19:44:22.232 INFO:tasks.workunit.client.0.smithi040.stderr:+ for f in '$BINARIES$SOURCES' 2018-11-01T19:44:22.232 INFO:tasks.workunit.client.0.smithi040.stderr:+ rm -f /home/ubuntu/cephtest/mnt.0/client.0/tmp/hello_world.cc 2018-11-01T19:44:22.233 INFO:tasks.workunit.client.0.smithi040.stderr:+ for f in '$BINARIES$SOURCES' 2018-11-01T19:44:22.233 INFO:tasks.workunit.client.0.smithi040.stderr:+ rm -f /home/ubuntu/cephtest/mnt.0/client.0/tmp/Makefile 2018-11-01T19:44:22.235 DEBUG:teuthology.orchestra.run:got remote process result: 2 2018-11-01T19:44:22.235 INFO:tasks.workunit:Stopping ['rados/test_librados_build.sh'] on client.0...
/a/nojha-2018-11-01_17:41:31-rados-master-distro-basic-smithi/3211856/
PR that could have caused this https://github.com/ceph/ceph/pull/24229
Related issues
History
#1 Updated by Neha Ojha over 5 years ago
2018-11-01T19:44:36.698 INFO:tasks.workunit.client.0.smithi138.stderr:In file included from /usr/include/rados/librados.hpp:11:0, 2018-11-01T19:44:36.699 INFO:tasks.workunit.client.0.smithi138.stderr: from /home/ubuntu/cephtest/mnt.0/client.0/tmp/rocksdb/include/rocksdb/utilities/env_librados.h:14, 2018-11-01T19:44:36.699 INFO:tasks.workunit.client.0.smithi138.stderr: from /home/ubuntu/cephtest/mnt.0/client.0/tmp/rocksdb/utilities/env_librados.cc:4: 2018-11-01T19:44:36.699 INFO:tasks.workunit.client.0.smithi138.stderr:/usr/include/rados/buffer.h:657:61: error: expected ',' before ')' token 2018-11-01T19:44:36.699 INFO:tasks.workunit.client.0.smithi138.stderr: static_assert(sizeof(contiguous_filler) == sizeof(char*)); 2018-11-01T19:44:36.699 INFO:tasks.workunit.client.0.smithi138.stderr: ^ 2018-11-01T19:44:36.699 INFO:tasks.workunit.client.0.smithi138.stderr:/usr/include/rados/buffer.h:657:61: error: expected string-literal before ')' token 2018-11-01T19:44:36.874 INFO:tasks.workunit.client.0.smithi138.stdout:CMakeFiles/rocksdb-shared.dir/build.make:5486: recipe for target 'CMakeFiles/rocksdb-shared.dir/utilities/env_librados.cc.o' failed 2018-11-01T19:44:36.874 INFO:tasks.workunit.client.0.smithi138.stderr:make[3]: *** [CMakeFiles/rocksdb-shared.dir/utilities/env_librados.cc.o] Error 1 2018-11-01T19:44:36.874 INFO:tasks.workunit.client.0.smithi138.stderr:make[3]: *** Waiting for unfinished jobs.... 2018-11-01T19:44:37.158 INFO:tasks.workunit.client.0.smithi138.stdout:CMakeFiles/Makefile2:5422: recipe for target 'CMakeFiles/rocksdb-shared.dir/all' failed 2018-11-01T19:44:37.158 INFO:tasks.workunit.client.0.smithi138.stdout:CMakeFiles/Makefile2:4164: recipe for target 'CMakeFiles/rocksdb_env_librados_test.dir/rule' failed 2018-11-01T19:44:37.158 INFO:tasks.workunit.client.0.smithi138.stdout:Makefile:1460: recipe for target 'rocksdb_env_librados_test' failed 2018-11-01T19:44:37.159 INFO:tasks.workunit.client.0.smithi138.stderr:make[2]: *** [CMakeFiles/rocksdb-shared.dir/all] Error 2 2018-11-01T19:44:37.159 INFO:tasks.workunit.client.0.smithi138.stderr:make[1]: *** [CMakeFiles/rocksdb_env_librados_test.dir/rule] Error 2 2018-11-01T19:44:37.159 INFO:tasks.workunit.client.0.smithi138.stderr:make: *** [rocksdb_env_librados_test] Error 2 2018-11-01T19:44:37.160 DEBUG:teuthology.orchestra.run:got remote process result: 2
/a/nojha-2018-11-01_17:41:31-rados-master-distro-basic-smithi/3211863/
#2 Updated by Neha Ojha over 5 years ago
- Subject changed from /usr/include/rados/buffer.h:657:61: error: expected ‘,’ before ‘)’ token to /usr/include/rados/buffer.h:657:61: error: expected ',' before ')' token
#3 Updated by Radoslaw Zarzynski over 5 years ago
- Status changed from New to In Progress
- Assignee set to Radoslaw Zarzynski
#4 Updated by Radoslaw Zarzynski over 5 years ago
The no-message-taking-variant of static_assert has been introduced in C++17. The code is being compiled with -std=c++11.
#5 Updated by Radoslaw Zarzynski over 5 years ago
Ceph has already moved to C++17. The main question is: have we transitioned to C++17 also our public headers xor put a constraint on language we can use in them?
#6 Updated by Radoslaw Zarzynski over 5 years ago
- Status changed from In Progress to Fix Under Review
A fix is already available. See Sage's PR: https://github.com/ceph/ceph/pull/24835.
#7 Updated by Josh Durgin over 5 years ago
- Status changed from Fix Under Review to Resolved
#8 Updated by Yuri Weinstein over 5 years ago
- Related to Bug #37392: "/usr/bin/ld: cannot find -lradospp" in rados mimic added