Project

General

Profile

Cleanup #36563

mgr/dashboard: Improve SummaryService's getCurrentSummary method

Added by Tiago Melo over 2 years ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/general
Target version:
% Done:

0%

Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently this method will return the value of the summary, even if we haven't receive any.
If you call this method expecting to have some data, you code will probably fail or do nothing.

I propose we return an observable, that will only be resolved when we have some data.
Then, in our code, we could subscribe to this and be sure it would always work.

This could be applied to all situation where we are subscribing to the summary and immediately unsubscribe after we get some data.
For example, when determining the releaseName.


Related issues

Copied to mgr - Backport #45855: octopus: mgr/dashboard: Improve SummaryService's getCurrentSummary method Resolved

History

#1 Updated by Tiago Melo 9 months ago

  • Status changed from New to In Progress
  • Assignee set to Tiago Melo
  • Tags deleted (low-hanging-fruit)

#2 Updated by Tiago Melo 9 months ago

  • Pull request ID set to 35031

#3 Updated by Tiago Melo 9 months ago

  • Status changed from In Progress to Fix Under Review

#4 Updated by Alfonso Martínez 9 months ago

  • Backport set to octopus

#5 Updated by Lenz Grimmer 8 months ago

  • Status changed from Fix Under Review to Pending Backport
  • Target version set to v16.0.0

#6 Updated by Nathan Cutler 8 months ago

  • Copied to Backport #45855: octopus: mgr/dashboard: Improve SummaryService's getCurrentSummary method added

#7 Updated by Nathan Cutler 7 months ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF