Actions
Cleanup #36563
closedmgr/dashboard: Improve SummaryService's getCurrentSummary method
% Done:
0%
Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:
Description
Currently this method will return the value of the summary, even if we haven't receive any.
If you call this method expecting to have some data, you code will probably fail or do nothing.
I propose we return an observable, that will only be resolved when we have some data.
Then, in our code, we could subscribe to this and be sure it would always work.
This could be applied to all situation where we are subscribing to the summary and immediately unsubscribe after we get some data.
For example, when determining the releaseName.
Updated by Tiago Melo almost 4 years ago
- Status changed from New to In Progress
- Assignee set to Tiago Melo
- Tags deleted (
low-hanging-fruit)
Updated by Tiago Melo almost 4 years ago
- Status changed from In Progress to Fix Under Review
Updated by Lenz Grimmer almost 4 years ago
- Status changed from Fix Under Review to Pending Backport
- Target version set to v16.0.0
Updated by Nathan Cutler almost 4 years ago
- Copied to Backport #45855: octopus: mgr/dashboard: Improve SummaryService's getCurrentSummary method added
Updated by Nathan Cutler almost 4 years ago
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".
Updated by Ernesto Puerta about 3 years ago
- Project changed from mgr to Dashboard
- Category changed from 132 to General
Actions