Actions
Bug #3646
closedpg_temp with two down/out osds
% Done:
0%
Source:
Development
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Encountered on MassEffect, osdmap is attached.
{ "pgid": "2.25",
"osds": [
30,
21]},Looking over the OSDMonitor code, I don't see anything to remove pg_temp mappings which contain only down/out OSDs. It seems like when we prepare a new map, we should scan pg_temp for any mappings containing only down osds and remove them. Thoughts?
Files
Updated by Sage Weil over 11 years ago
Good point. We can also remove mappings that match the crush result. Although that is a more expensive scan by the monitor.
Updated by Samuel Just over 11 years ago
It actually does that already. OSDMonitor::remove_redundant_pg_temp(). I'll hook in around there for the fix, doing it in apply_incremental would be bad since it would change the result of applying incremental OSDMaps between versions.
Updated by Sage Weil about 11 years ago
- Status changed from In Progress to Resolved
Actions