Project

General

Profile

Bug #36404

mgr/dashboard: Can not delete RBD with snapshots

Added by Volker Theile about 2 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/rbd
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

If there are snapshot sassigned to a RBD, then it is not possible to delete them. In my opinion the deletion should be forced automatically if it is moved to trash and the trash is purged then.
Otherwise it is necessary to explicitely delete every snapshot manually before i can delete a RBD.

screenshot.gif View (990 KB) Volker Theile, 10/11/2018 11:50 AM


Related issues

Related to mgr - Bug #42330: nautilus: mgr/dashboard: Error getting image configuration during deletion Resolved
Blocked by rbd - Feature #43958: librbd: Add support for RBD Snapshot purge in python bindings Rejected

History

#1 Updated by Patrick Seidensal about 2 years ago

It might be a good idea to tell the user that the RBD, which is about to be deleted still has some associated snapshots which will also be deleted if the user proceeds.

edit

Or maybe even show the snapshots in the deletion dialog, so that the user knows which and how many snapshots will be removed.

#2 Updated by Ricardo Marques about 2 years ago

  • Priority changed from Normal to High

#3 Updated by Ricardo Marques about 2 years ago

  • Tags set to low-hanging-fruit

#4 Updated by Ricardo Marques about 2 years ago

  • Priority changed from High to Normal

#5 Updated by Ricardo Marques about 2 years ago

  • Assignee deleted (Ricardo Marques)

#6 Updated by Laura Paduano almost 2 years ago

Traceback from the mgr.log:

2018-11-28 11:44:01.824 7f126de33700 -1 librbd::image::RemoveRequest: 0x55fc7e529340 check_image_snaps: image has snapshots - not removing
2018-11-28 11:44:01.848 7f126b62e700 -1 librbd::api::Trash: remove: error removing image 10cb672ee0af, which is pending deletion
2018-11-28 11:44:01.856 7f126b62e700  0 mgr[dashboard] Error while calling Task(ns=rbd/trash/purge, md={'pool_name': u'test'})
Traceback (most recent call last):
  File "/ceph/src/pybind/mgr/dashboard/tools.py", line 530, in _run
    val = self.task.fn(*self.task.fn_args, **self.task.fn_kwargs)
  File "/ceph/src/pybind/mgr/dashboard/services/exception.py", line 44, in wrapper
    return f(*args, **kwargs)
  File "/usr/lib64/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "/ceph/src/pybind/mgr/dashboard/services/exception.py", line 102, in handle_rbd_error
    raise DashboardException(e, component='rbd')
DashboardException: [errno 39] error deleting image from trash

#7 Updated by Lenz Grimmer about 1 year ago

  • Tags set to low-hanging-fruit, usability, management
  • Target version changed from v14.0.0 to v15.0.0
  • Tags deleted (low-hanging-fruit)

#8 Updated by Lenz Grimmer 10 months ago

  • Assignee set to Tiago Melo

#9 Updated by Tiago Melo 10 months ago

  • Blocked by Feature #43958: librbd: Add support for RBD Snapshot purge in python bindings added

#10 Updated by Tiago Melo 10 months ago

  • Status changed from New to In Progress

#11 Updated by Tiago Melo 10 months ago

  • Pull request ID set to 33067
Few questions regarding this:
  1. If there are protected snapshots, should we disable the deletion or unprotect it automatically and delete everything?
  2. If there are protected snapshots and the RBD is in the Trash how should we proceed?
    Unprotect automatically and then delete?
    The user no longer has access to the snapshot list and can't unprotect them.
  3. Should it be allowed to move an RBD to trash if it has protected snapshots?

#12 Updated by Tiago Melo 10 months ago

After discussing this at this mornings standup, we decided to display a warning regarding the unprotected snapshots and if the user confirms he wants to delete, we unprotect the snapshots automatically and delete the rbd and all snapshots.

#13 Updated by Tiago Melo 9 months ago

  • Status changed from In Progress to Fix Under Review

#14 Updated by Lenz Grimmer 9 months ago

  • Status changed from Fix Under Review to Resolved

#15 Updated by Nathan Cutler 8 months ago

  • Related to Bug #42330: nautilus: mgr/dashboard: Error getting image configuration during deletion added

#16 Updated by Nathan Cutler 8 months ago

Backporting note: a manual (non-cherry-pick) backport to nautilus has been undertaken via #42330

Also available in: Atom PDF