Project

General

Profile

Feature #3527

osd: blacklist should cancel outstanding watches from blacklisted client

Added by Dan Mick about 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

While testing locking/fencing, I noticed that if an rbd client is blacklisted, it
receives ESHUTDOWN from any operation following; this unfortunately includes the
"remove watch" operation, which means that it exits with pending watches, which means
the image it was doing I/O to cannot be removed until the 30s timeout expires.

Blacklist should probably immediately expire and/or cancel outstanding watches from
the client being blacklisted.

Associated revisions

Revision ab0da283 (diff)
Added by David Zafman over 6 years ago

osd: Drop watchers from blacklisted clients

On blackist addition or populate ObjectContext
check watcher address against blacklist
Add dout() of the watcher's ip address

fixes: #3527

Signed-off-by: David Zafman <>

History

#1 Updated by Sage Weil over 6 years ago

  • Tracker changed from Bug to Feature

#2 Updated by Sage Weil over 6 years ago

  • Subject changed from blacklist should cancel outstanding watches from blacklisted client to osd: blacklist should cancel outstanding watches from blacklisted client

#3 Updated by Sage Weil over 6 years ago

  • translation missing: en.field_story_points set to 5.00

#4 Updated by Sage Weil over 6 years ago

  • Target version set to v0.63

#5 Updated by Sage Weil over 6 years ago

  • Target version changed from v0.63 to v0.64

#6 Updated by Ian Colle over 6 years ago

  • Assignee set to David Zafman

#7 Updated by Ian Colle over 6 years ago

  • Status changed from New to In Progress

#8 Updated by Sage Weil over 6 years ago

  • Target version changed from v0.64 to v0.65

#9 Updated by David Zafman over 6 years ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF