Project

General

Profile

Fix #3500

Ceph - Feature #10509: mon: wishlist tracking ticket

mon: use new MessageRef and intrusive_ptr's throughout the Monitor's message handling

Added by Joao Eduardo Luis about 10 years ago. Updated over 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Monitor
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Using MessageRef and intrusive_ptr's for all the messages should allow us to simplify the code and avoid memory leaks when a message is not properly discarded.

However, this will involve a serious scrub on the monitor's code as these changes should go all the way up to Monitor::_ms_dispatch(). Ideally it should be done all the way up to the messenger subsystem, but that would certainly force us to implement it across all the ceph components, so a better approach would be to start doing it on smaller scale and climb our way up to the messenger.


Related issues

Related to CephFS - Bug #24306: mds: use intrusive_ptr to manage Message life-time Resolved

History

#1 Updated by Joao Eduardo Luis about 8 years ago

  • Assignee deleted (Joao Eduardo Luis)

#2 Updated by Joao Eduardo Luis about 8 years ago

  • Parent task set to #10509

#3 Updated by Patrick Donnelly over 4 years ago

  • Tracker changed from Subtask to Fix
  • Project changed from Ceph to RADOS
  • Category deleted (Monitor)
  • Component(RADOS) Monitor added

#4 Updated by Patrick Donnelly over 4 years ago

  • Related to Bug #24306: mds: use intrusive_ptr to manage Message life-time added

Also available in: Atom PDF