Project

General

Profile

Bug #3451

qa: rpm autobuilt packages should get 'git describe' version

Added by Sage Weil over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The autobuilt rpm packages currently get the version from the previous release (e.g., '0.53') instead of the git describe version (e.g., 'v0.53-635-g456c90b'). they need to get the accurate version or anarchy will prevail. this is currently handled for debs by the build_snapshot[_native].sh script in ceph-build.git.

History

#1 Updated by Anonymous over 11 years ago

RPM provides a version and a release field. Currently the version is generated by configure and the release field is hardcoded to 6.{dist}. I've added an RPM_RELEASE variable to configure.ac that picks up the git describe commit count and sha1 fields and substitutes it ceph.spec. This will set the the RPM release filed similar to the following:

[centos@gitbuilder-centos6-amd64 x86_64]$ rpm -qip ceph-0.53-658.g3b26a4d.el6.x86_64.rpm
Name : ceph Relocations: (not relocatable)
Version : 0.53 Vendor: (none)
Release : 658.g3b26a4d.el6 Build Date: Thu 08 Nov 2012 04:17:26 PM EST
...

The resulting rpm file names will look like:

ceph-test-0.53-658.g3b26a4d.el6.x86_64.rpm

Some simple tests showed that rpm upgrades of packages happened correctly, and downgrades required the --oldpackage keyword.

For tagged releases, the release field will just have the distribution abbreviation, or in the case of SuSE releases will be blank, similar to:

ceph-test-0.54-el6.x86_64.rpm or ceph-test-0.54.x86_64.rpm

#2 Updated by Sage Weil over 11 years ago

  • Priority changed from High to Urgent

#3 Updated by Anonymous over 11 years ago

Commit ff5ee98f1c97b286a81848dc3b70ea523d8fe95e in master.

#4 Updated by Anonymous over 11 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF