Project

General

Profile

Actions

Bug #3361

closed

don't log secrets

Added by Anonymous over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
High
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

 void KeyRing::import(KeyRing& other)
 {
   for (map<EntityName, EntityAuth>::iterator p = other.keys.begin();
        p != other.keys.end();
        ++p) {
     dout(10) << " importing " << p->first << " " << p->second << dendl;

 void AuthMonitor::import_keyring(KeyRing& keyring)
 {
   for (map<EntityName, EntityAuth>::iterator p = keyring.get_keys().begin();
        p != keyring.get_keys().end();
        p++) {
     KeyServerData::Incremental auth_inc;
     auth_inc.name = p->first;
     auth_inc.auth = p->second; 
     auth_inc.op = KeyServerData::AUTH_INC_ADD;
     dout(10) << " importing " << auth_inc.name << " " << auth_inc.auth << dendl;
     push_cephx_inc(auth_inc);
   }
 }

 bool AuthMonitor::prepare_command(MMonCommand *m)
 {
...
       auth_inc.op = KeyServerData::AUTH_INC_ADD;
       dout(10) << " importing " << auth_inc.name << " " << auth_inc.auth << dendl;
Actions #1

Updated by Sage Weil over 11 years ago

  • Status changed from New to 12
  • Priority changed from Normal to High

there's a larger audit that needs to be done here. soon!

Actions #2

Updated by Joao Eduardo Luis over 11 years ago

  • Assignee set to Joao Eduardo Luis

I will take care of this in the morning, and will make sure nothing else of value is leaked onto the logs.

Actions #3

Updated by Joao Eduardo Luis over 11 years ago

  • Status changed from 12 to Fix Under Review
Actions #4

Updated by Joao Eduardo Luis over 11 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF