Project

General

Profile

Feature #3310

ceph-deploy: handle stderr from commands better

Added by Anonymous over 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
ceph-deploy
Target version:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently, we use pushy (http://pypi.python.org/pypi/pushy/ ) for RPC-over-SSH to the target node, and don't really do anything about the stderr of the commands we run on the node.

Current user experience is that sometimes stderr is visible, sometimes not. This seems to be true even for a loop that does the same actions for every entry (though there's a chance the "stderr not seen" was from steps that only needed for the first iteration for a particular host; e.g. if a keyring file is already present, you don't see the noise from putting it in place).

What ever the current situation, unify stderr handling. Ideal:

- no noise on successful run
- see stderr of commands on verbose runs (e.g. "ceph-deploy v osd ...")
see stderr of any full run that failed; that is, for "ceph-deploy osd host1:sdb host2:sdb", if ceph-disk-prepare fails on host2:sdb, we should see full stderr of everything that happened on host2, but none of what happened on host1)
- all stderr output is clearly prefixed to identify what host and what command it is coming from

History

#1 Updated by Anonymous over 7 years ago

  • Description updated (diff)

#2 Updated by Sage Weil over 7 years ago

  • Category set to ceph-deploy

#3 Updated by Neil Levine about 7 years ago

  • Status changed from New to 12

#4 Updated by Neil Levine about 7 years ago

Some further suggestions:

  • stdout should show useful a useful summary about is happening ("Installing packages" rather than "Installing Package ceph-common"), which can be supressed with -q. Shouldn't have DEBUG as a prefix!
  • a log should contain the actual detail of actions (eg installing package ceph-common) so failures can be debugged. Log should be on each node (eg /var/log/ceph/ceph-deploy.log). Aggregated log with node id prefixed should be on admin machine running command
  • script error should generate a graceful message which points user to the log. We should avoid throwing a bunch of python exception errors to stderr

#5 Updated by Ian Colle about 7 years ago

  • Target version set to v0.61 - Cuttlefish

#6 Updated by Sage Weil about 7 years ago

  • Target version changed from v0.61 - Cuttlefish to v0.62a

#7 Updated by Sage Weil about 7 years ago

  • Target version changed from v0.62a to v0.62b

#8 Updated by Sage Weil about 7 years ago

  • Target version changed from v0.62b to v0.64

#9 Updated by Sage Weil about 7 years ago

  • translation missing: en.field_story_points set to 5.00

#10 Updated by Anonymous about 7 years ago

  • Target version deleted (v0.64)

#11 Updated by Sage Weil about 7 years ago

  • Target version set to v0.64

#12 Updated by Sage Weil about 7 years ago

  • Status changed from 12 to Resolved

Also available in: Atom PDF