Project

General

Profile

Actions

Bug #3253

closed

ceph-disk-activate: support clusters not named "ceph"

Added by Anonymous over 11 years ago. Updated over 6 years ago.

Status:
Won't Fix
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
luminous,jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When activating an osd data disk, read mount options from ceph.conf, mount the disk, read the cluster uuid, find the right config file, read mount options from that; if they differ, unmount & remount with the new options; only then proceed.

Actions #1

Updated by Anonymous over 11 years ago

  • Tracker changed from Bug to Feature
Actions #2

Updated by Anonymous over 11 years ago

  • Translation missing: en.field_position set to 232
Actions #3

Updated by Sage Weil about 11 years ago

  • Translation missing: en.field_position deleted (262)
  • Translation missing: en.field_position set to 55
Actions #4

Updated by Sage Weil about 11 years ago

  • Translation missing: en.field_position deleted (55)
  • Translation missing: en.field_position set to 43
Actions #5

Updated by Sage Weil about 11 years ago

  • Target version set to v0.60
Actions #6

Updated by Sage Weil about 11 years ago

  • Status changed from New to Resolved
Actions #7

Updated by Dan Mick about 11 years ago

Confused; I still see this in mount_activate:

  1. TODO always using mount options from cluster=ceph for
  2. now; see http://tracker.newdream.net/issues/3253
    mount_options = get_conf(
    cluster='ceph',
Actions #8

Updated by Alfredo Deza almost 7 years ago

  • Project changed from devops to Ceph
  • Status changed from Resolved to New
  • Target version deleted (v0.60)

The function `mount_activate` still has this hard coded, and it references this ticket.

def mount_activate(
    dev,
    activate_key_template,
    init,
    dmcrypt,
    dmcrypt_key_dir,
    reactivate=False,
):

    if dmcrypt:
        part_uuid = get_partition_uuid(dev)
        dev = dmcrypt_map(dev, dmcrypt_key_dir)
    try:
        fstype = detect_fstype(dev=dev)
    except (subprocess.CalledProcessError,
            TruncatedLineError,
            TooManyLinesError) as e:
        raise FilesystemTypeError(
            'device {dev}'.format(dev=dev),
            e,
        )

    # TODO always using mount options from cluster=ceph for
    # now; see http://tracker.newdream.net/issues/3253
    mount_options = get_mount_options(cluster='ceph', fs_type=fstype)

    path = mount(dev=dev, fstype=fstype, options=mount_options)

Actions #9

Updated by Loïc Dachary over 6 years ago

  • Tracker changed from Feature to Bug
  • Status changed from New to In Progress
  • Assignee set to Loïc Dachary
  • Regression set to No
  • Severity set to 3 - minor
Actions #10

Updated by Loïc Dachary over 6 years ago

  • Backport set to luminous,jewel
Actions #11

Updated by Kefu Chai over 6 years ago

  • Status changed from In Progress to Fix Under Review
Actions #12

Updated by Loïc Dachary over 6 years ago

  • Assignee deleted (Loïc Dachary)
Actions #13

Updated by Kefu Chai over 6 years ago

  • Status changed from Fix Under Review to Won't Fix
Actions

Also available in: Atom PDF