Project

General

Profile

Bug #2822

rbd: ASSIGN_BID both mutates object and returns data

Added by Sage Weil over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
argonaut
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

It's not okay to mutate data and return data, because when resending the operation (e.g., due to a connection fault, crush mapping change, whatever) we may get the a 0 success ("already did this op") but no data.


2012-07-22T21:40:59.821 DEBUG:teuthology.orchestra.run:Running: 'LD_LIBRARY_PATH=/tmp/cephtest/binary/usr/local/lib /tmp/cephtest/enable-coredump /tmp/cephtest/binary/usr/local/bin/ceph-coverage /tmp/cephtest/archive/coverage /tmp/cephtest/binary/usr/local/bin/rbd -c /tmp/cephtest/ceph.conf -p rbd create -s 10240 client.0.0'
2012-07-22T21:41:00.000 INFO:teuthology.orchestra.run.err:2012-07-22 21:40:59.990425 7ffe3c27b700  0 -- 10.214.132.30:0/1012854 >> 10.214.132.29:6800/29918 pipe(0x7ffe280055a0 sd=9 pgs=8 cs=1 l=1).injecting socket failure
2012-07-22T21:41:00.174 INFO:teuthology.orchestra.run.err:create error: (74) Bad message
2012-07-22T21:41:00.174 INFO:teuthology.orchestra.run.err:2012-07-22 21:41:00.164788 7ffe427f2780 -1 librbd: failed to assign a block name for image
2012-07-22T21:41:00.190 ERROR:teuthology.contextutil:Saw exception from nested tasks
Traceback (most recent call last):
  File "/var/lib/teuthworker/teuthology/teuthology/contextutil.py", line 25, in nested
    vars.append(enter())
  File "/usr/lib/python2.6/contextlib.py", line 16, in __enter__
    return self.gen.next()
  File "/var/lib/teuthworker/teuthology/teuthology/task/rbd.py", line 57, in create_image
    name,
  File "/var/lib/teuthworker/teuthology/teuthology/orchestra/remote.py", line 40, in run
    r = self._runner(client=self.ssh, **kwargs)
  File "/var/lib/teuthworker/teuthology/teuthology/orchestra/run.py", line 257, in run
    r.exitstatus = _check_status(r.exitstatus)
  File "/var/lib/teuthworker/teuthology/teuthology/orchestra/run.py", line 253, in _check_status
    raise CommandFailedError(command=r.command, exitstatus=status)

ubuntu@teuthology:/a/sage-2012-07-22_21:26:14-regression-wip-msgr-testing-basic/16171$ cat config.yaml 
kernel: &id001
  kdb: true
  sha1: 77dca1ac33894de22b1740bb9cf6b8ef6429c700
nuke-on-error: true
overrides:
  ceph:
    conf:
      global:
        ms inject socket failures: 200
    fs: btrfs
    log-whitelist:
    - slow request
    sha1: 6eed7678bfad69cda7ff405697ee3c1436cdb5e6
  workunit:
    sha1: 6eed7678bfad69cda7ff405697ee3c1436cdb5e6
roles:
- - mon.a
  - mon.c
  - osd.0
  - osd.1
  - osd.2
- - mon.b
  - mds.a
  - osd.3
  - osd.4
  - osd.5
- - client.0
targets:
  ubuntu@plana48.front.sepia.ceph.com: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDsCaLzaU8wDT1/BiLAHUmUtQvqFARiOA7nnPsNXdBU9wHc/UasC7sVih6CmOqRjBkBxdcVJMTbBgxJyPYC58CGDv4stD3Puhtv3rq+FXDUkGC4rL7LkwnDuaMLdozD23qeXxb6OwBTnR7pw7laaXlmDLmQ7OR8/zwBhi4/RlGwioH4mBQQclRPPJCoRuYiaIVUBwetPhfdbFAcRDF45BX0F1g+0Zn9RIl507/5b++9J/7d51RwJt69AX/iacMKEf24XgY9me1ydS69dOxZ7yQfPrrLsMH4ehleURSkBnpU5BuSWfhx4aKylth0rFSe7lVaarxiI0Dq/c0nMeBGiclj
  ubuntu@plana49.front.sepia.ceph.com: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCsodFx35LkTvKGlOrQT7Zt/AuvpUOoNz4sM8ovIxIjn/AJliZfup2KAhO/VRUpcndtJMy0eAp/v6wMy9bP0tqTNbeZ3q+zzzLuwnoCOQ0relggohTE7lzLDVLb/MHCQlxpLifwUrwQpVdiUfJ2B5mcGyMr2Lku4TcC3BrgPKuaXLkGHZl0aaShLfr6PbTvDjqI+IDT4E4iKd65KhzLuzDqAIwuZyoifiG+5KYYsoIZmCHidTZYHdf6utnBzP9jTQHroZR5kE/qbVnoL1tT9vvXWLcG7y2PB3UMmIOJmRXlys2/My5iRSC+1Wd9nBxcwE3BgWHknGQhrwkMl0uC+vH3
  ubuntu@plana50.front.sepia.ceph.com: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDVJ+lkgUdkr27WFzrmwSQU22m+pFIiqzhfcO4Hinu8A8uyP4FIephrEcq4Rrt4hp14Syb1pxXisV6UKwAZKikDoD1Wl0LSro4TzOs6HuMEhfvzdnISvyzE3f2w0cj1zE61rHFYfPNF14b9fkE3wBf2Vb4i6ReaN2/Yd12J/xO52tJH1lPxgsFoAIRMjdQMbfVwPU6kK9SY4ngt9iLjge6gZ0O9Jwe2vrgD6+LNoMY9qvNjgRvQdCTi85OQwitU0ZMZdGC0cQ/oNbKd+yW92rW9Wu6dcyKSisesRcm7lbtS6X2uUup+u3vWze7coT+Py3TdNW6nGpIg4muyvqHfSinz
task:
- ceph:
    conf:
      client:
        rbd cache: false
tasks:
- internal.lock_machines: 3
- internal.save_config: null
- internal.check_lock: null
- internal.connect: null
- internal.check_conflict: null
- kernel: *id001
- internal.base: null
- internal.archive: null
- internal.coredump: null
- internal.syslog: null
- internal.timer: null
- chef: null
- clock: null
- ceph: null
- qemu:
    all:
      test: https://raw.github.com/ceph/ceph/master/qa/workunits/suites/bonnie.sh

History

#1 Updated by Sage Weil over 11 years ago

ubuntu@teuthology:/a/sage-2012-07-22_21:26:14-regression-wip-msgr-testing-basic/16193 too

#2 Updated by Sage Weil over 11 years ago

  • Subject changed from rbd: EBADMSG with ms failures to rbd: ASSIGN_BID both mutates object and returns data
  • Description updated (diff)
  • Priority changed from High to Urgent

#3 Updated by Sage Weil over 11 years ago

  • Priority changed from Urgent to High

#4 Updated by Sage Weil over 11 years ago

  • Status changed from New to Resolved
  • Backport set to argonaut

Also available in: Atom PDF