Project

General

Profile

Bug #2772

rados bench -t broken

Added by Yehuda Sadeh over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
argonaut
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The -t parameter has being assigned to rados cppool (target pool), but apparently it was already being used for rados bench which is now broken.

History

#1 Updated by Sage Weil over 11 years ago

let's just make it --target-pool or similar. this is an uncommon enough command that it doesn't really need a single-char arg alias

#2 Updated by Yehuda Sadeh over 11 years ago

  • Description updated (diff)

#3 Updated by Yehuda Sadeh over 11 years ago

actually the -t param is for 'rados cp' which is for an object, not for cppool.

#4 Updated by Dan Mick over 11 years ago

FWIW, I hacked up a patch last night (changed -t to -n to avoid conflicts, and made some changes to the usage message).

diff --git a/src/rados.cc b/src/rados.cc
index 7b7248f..c7f5dd1 100644
--- a/src/rados.cc
++ b/src/rados.cc
@ -76,7 +76,7 @ void usage(ostream& out)
" mksnap <snap-name> create snap <snap-name>\n"
" rmsnap <snap-name> remove snap <snap-name>\n"
" rollback <obj-name> <snap-name> roll back object to snap <snap-name>\n\n"
" bench <seconds> write|seq|rand [-t concurrent_operations]\n"
" bench <seconds> write|seq|rand [-n concurrent_operations]\n"
" default is 16 concurrent IOs and 4 MB ops\n"
" load-gen [options] generate load on the cluster\n"
" listomapkeys <obj-name> list the keys in the object map\n"
@ -120,6 +120,9 @ STR ")\n"
"BENCH OPTIONS:\n"
" --show-time\n"
" prefix output with date/time\n"
" -n N\n"
" --concurrent-ios = N\n"
" number of concurrent I/O operations\n"
"\n"
"LOAD GEN OPTIONS:\n"
" --num-objects total number of objects\n"
@ -1549,7 +1552,7 @ int main(int argc, const char *argv)
opts["object_locator"] = val;
} else if (ceph_argparse_witharg(args, i, &val, "--category", (char
)NULL)) {
opts["category"] = val;
} else if (ceph_argparse_witharg(args, i, &val, "-t", "--concurrent-ios", (char*)NULL)) {
} else if (ceph_argparse_witharg(args, i, &val, "-n", "--concurrent-ios", (char*)NULL)) {
opts["concurrent-ios"] = val;
} else if (ceph_argparse_witharg(args, i, &val, "--block-size", (char*)NULL)) {
opts["block-size"] = val;

#5 Updated by Sage Weil over 11 years ago

we can't change bench flags.

just don't make a short one-char flag for the target... use --target or whatever instead

#6 Updated by Sage Weil over 11 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF