Project

General

Profile

Cleanup #2623

filestore btrfs trans should be removed

Added by Dan Mick over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
OSD
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

On Wed, 20 Jun 2012, Stefan Priebe - Profihost AG wrote:

Hello list,

i've looked at the wiki (http://ceph.com/wiki/Ceph.conf) but there is no exact
desciption what filestore btrfs trans does. It seems it is false by default.

Should it be enabled when using btrfs?

Nope. This is the obsolete trans start/end ioctls that we don't use. We
should remove this code.

sage

Associated revisions

Revision 7044192d (diff)
Added by Sage Weil over 11 years ago

filestore: remove btrfs start/end transaction ioctl code

This was an ill-conceived approach to getting atomic transactions out of
btrfs. It doesn't offer rollback, which means that any error means we need
to wedge the file system and reboot in order to avoid corrupting the
data set. And that's silly!

Snapshots are more robust and only marginally slower (because we have to
quiesce our writes while waiting for the snap to start, and btrfs resume
work in-kernel slightly faster...maybe).

Fixes: #2623
Signed-off-by: Sage Weil <>

History

#1 Updated by Sage Weil over 11 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF