Project

General

Profile

Bug #25096

@RbdTasks decorator don't support optional query_params

Added by Tiago Melo about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
dashboard/general
Target version:
-
Start date:
07/25/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

I found this problem in the following code:

@RbdTask('trash/purge', ['{pool_name}'], 2.0)
@RESTController.Collection('POST', query_params=['pool_name'])
def purge(self, pool_name=None):

I have a optional "pool_name" query_params and in some situations I don't want to sent the it the server.
It works well for the @RESTController and the method, but the @RbdTask decorator will throw an error because it always expects it to have a value.

History

#1 Updated by Ricardo Dias about 1 year ago

  • Status changed from New to In Progress

#2 Updated by Ricardo Dias about 1 year ago

  • Status changed from In Progress to Need Review

#3 Updated by Kefu Chai about 1 year ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF