Project

General

Profile

Backport #25044

mimic: overhead of g_conf->get_val<type>("config name") is high

Added by Patrick Donnelly over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Release:
mimic
Crash signature (v1):
Crash signature (v2):


Related issues

Copied from CephFS - Cleanup #24820: overhead of g_conf->get_val<type>("config name") is high Resolved 07/08/2018

History

#1 Updated by Patrick Donnelly over 4 years ago

  • Copied from Cleanup #24820: overhead of g_conf->get_val<type>("config name") is high added

#2 Updated by Prashant D over 4 years ago

  • Status changed from New to Need More Info

The ConfigProxy is not defined in mimic and needs to backported :

In file included from /home/pdvian/backport/ceph7_mimic/src/mds/MDSRank.h:31:0,
from /home/pdvian/backport/ceph7_mimic/src/mds/Server.cc:21:
/home/pdvian/backport/ceph7_mimic/src/mds/MDCache.h:717:33: error: ‘ConfigProxy’ does not name a type
void handle_conf_change(const ConfigProxy& conf,
^~~~~~~~~
In file included from /home/pdvian/backport/ceph7_mimic/src/mds/Server.cc:21:0:
/home/pdvian/backport/ceph7_mimic/src/mds/MDSRank.h: In member function ‘void MDSRank::handle_conf_change(const md_config_t*, const std::set<std::__cxx11::basic_string<char> >&)’:
/home/pdvian/backport/ceph7_mimic/src/mds/MDSRank.h:226:57: error: invalid conversion from ‘const md_config_t*’ to ‘int’ [-fpermissive]
mdcache->handle_conf_change(conf, changed, mdsmap);
^
In file included from /home/pdvian/backport/ceph7_mimic/src/mds/MDSRank.h:31:0,
from /home/pdvian/backport/ceph7_mimic/src/mds/Server.cc:21:
/home/pdvian/backport/ceph7_mimic/src/mds/MDCache.h:717:8: note: initializing argument 1 of ‘void MDCache::handle_conf_change(const int&, const std::set<std::__cxx11::basic_string<char> >&, const MDSMap&)’
void handle_conf_change(const ConfigProxy& conf,
^~~~~~~~~~~~~~~~
In file included from /home/pdvian/backport/ceph7_mimic/src/mds/Server.cc:27:0:
/home/pdvian/backport/ceph7_mimic/src/mds/MDBalancer.h: At global scope:
/home/pdvian/backport/ceph7_mimic/src/mds/MDBalancer.h:43:33: error: ‘ConfigProxy’ does not name a type
void handle_conf_change(const ConfigProxy& conf,
^~~~~~~~~
make3:
[src/mds/CMakeFiles/mds.dir/build.make:231: src/mds/CMakeFiles/mds.dir/Server.cc.o] Error 1
make2:
[CMakeFiles/Makefile2:5456: src/mds/CMakeFiles/mds.dir/all] Error 2
make2: *
* Waiting for unfinished jobs....

#3 Updated by Patrick Donnelly over 4 years ago

  • Assignee set to Zheng Yan

Zheng, PTAL.

#4 Updated by Zheng Yan over 4 years ago

  • Status changed from Need More Info to In Progress

#5 Updated by Nathan Cutler over 4 years ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved
  • Target version set to v13.2.2

Also available in: Atom PDF